Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tilak Tangudu <tilak.tangudu@intel.com>
To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: ville.syrjala@intel.com
Subject: [Intel-gfx] [PATCH v3] drm/i915/rpm: Enable runtime pm autosuspend by default
Date: Tue, 16 Nov 2021 21:22:38 +0530	[thread overview]
Message-ID: <20211116155238.3226516-1-tilak.tangudu@intel.com> (raw)

v1: Enable runtime pm autosuspend by default for Gen12
and later versions.

v2: Enable runtime pm autosuspend by default for all
platforms(Syrjala Ville)

v3: Change commit message(Nikula Jani)
Let's enable runtime pm autosuspend by default everywhere.
So, we can allow D3hot and bigger power savings on idle scenarios.

But at this time let's not touch the autosuspend_delay time,
what caused some regression on our previous attempt.

Also, the latest identified issue on GuC PM has been fixed by
commit 1a52faed3131 ("drm/i915/guc: Take GT PM ref when deregistering
context")

Signed-off-by: Tilak Tangudu <tilak.tangudu@intel.com>
---
 drivers/gpu/drm/i915/intel_runtime_pm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
index 0d85f3c5c526..22dab36afcb6 100644
--- a/drivers/gpu/drm/i915/intel_runtime_pm.c
+++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
@@ -590,6 +590,9 @@ void intel_runtime_pm_enable(struct intel_runtime_pm *rpm)
 		pm_runtime_use_autosuspend(kdev);
 	}
 
+	/* Enable by default */
+	pm_runtime_allow(kdev);
+
 	/*
 	 * The core calls the driver load handler with an RPM reference held.
 	 * We drop that here and will reacquire it during unloading in
-- 
2.25.1


             reply	other threads:[~2021-11-16 16:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16 15:52 Tilak Tangudu [this message]
2021-11-17  0:38 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/rpm: Enable runtime pm autosuspend by default (rev3) Patchwork
2021-11-17 22:59 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/rpm: Enable runtime pm autosuspend by default (rev4) Patchwork
2021-11-19 10:39   ` Gupta, Anshuman
2021-11-19 17:24     ` Vudum, Lakshminarayana
2021-11-19  9:56 ` [Intel-gfx] [PATCH v3] drm/i915/rpm: Enable runtime pm autosuspend by default Gupta, Anshuman
2021-11-19 17:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/rpm: Enable runtime pm autosuspend by default (rev4) Patchwork
2021-11-19 21:22 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-11-22 13:48 ` [Intel-gfx] [PATCH v3] drm/i915/rpm: Enable runtime pm autosuspend by default Anshuman Gupta
2021-11-22 14:08   ` Rodrigo Vivi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211116155238.3226516-1-tilak.tangudu@intel.com \
    --to=tilak.tangudu@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox