Re: [Intel-gfx] [PATCH 3/3] drm/i915: Fix framestart_delay commens in VRR code

["Navare, Manasi" <manasi.d.navare@intel.com>]

On Wed, Nov 17, 2021 at 08:31:03PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Since I originally wrote these comments we decided to change our
> definition of framestart_delay from 0-3 to 1-4. Adjust the comments
> to match that new convention. The actual code was adjusted already.
> 
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>

Manasi

> ---
>  drivers/gpu/drm/i915/display/intel_vrr.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
> index db1c3902fc2d..139e8936edc5 100644
> --- a/drivers/gpu/drm/i915/display/intel_vrr.c
> +++ b/drivers/gpu/drm/i915/display/intel_vrr.c
> @@ -60,7 +60,7 @@ intel_vrr_check_modeset(struct intel_atomic_state *state)
>   * Between those two points the vblank exit starts (and hence registers get
>   * latched) ASAP after a push is sent.
>   *
> - * framestart_delay is programmable 0-3.
> + * framestart_delay is programmable 1-4.
>   */
>  static int intel_vrr_vblank_exit_length(const struct intel_crtc_state *crtc_state)
>  {
> @@ -138,13 +138,13 @@ intel_vrr_compute_config(struct intel_crtc_state *crtc_state,
>  			i915->window2_delay;
>  	else
>  		/*
> -		 * FIXME: s/4/framestart_delay+1/ to get consistent
> +		 * FIXME: s/4/framestart_delay/ to get consistent
>  		 * earliest/latest points for register latching regardless
>  		 * of the framestart_delay used?
>  		 *
>  		 * FIXME: this really needs the extra scanline to provide consistent
>  		 * behaviour for all framestart_delay values. Otherwise with
> -		 * framestart_delay==3 we will end up extending the min vblank by
> +		 * framestart_delay==4 we will end up extending the min vblank by
>  		 * one extra line.
>  		 */
>  		crtc_state->vrr.pipeline_full =
> -- 
> 2.32.0
>