Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Use to_root_gt() to refer to the root tile

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3706 bytes --]

Hi Andi,

I love your patch! Yet something to improve:

[auto build test ERROR on drm-tip/drm-tip]
[also build test ERROR on next-20211118]
[cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next drm/drm-next tegra-drm/drm/tegra/for-next airlied/drm-next v5.16-rc2]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Andi-Shyti/More-preparation-for-multi-gt-patches/20211121-213526
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: x86_64-randconfig-c007-20211121 (attached as .config)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/068a75571292e317e35752c1b078605dda122741
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Andi-Shyti/More-preparation-for-multi-gt-patches/20211121-213526
        git checkout 068a75571292e317e35752c1b078605dda122741
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from <built-in>:4:
   In file included from drivers/gpu/drm/i915/display/intel_de.h:9:
>> drivers/gpu/drm/i915/i915_drv.h:1756:1: error: all paths through this function will call itself [-Werror,-Winfinite-recursion]
   {
   ^
   1 error generated.
--
   In file included from drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c:12:
>> drivers/gpu/drm/i915/i915_drv.h:1756:1: error: all paths through this function will call itself [-Werror,-Winfinite-recursion]
   {
   ^
   drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c:59:6: error: no previous prototype for function 'intel_pxp_debugfs_register' [-Werror,-Wmissing-prototypes]
   void intel_pxp_debugfs_register(struct intel_pxp *pxp, struct dentry *gt_root)
        ^
   drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c:59:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void intel_pxp_debugfs_register(struct intel_pxp *pxp, struct dentry *gt_root)
   ^
   static 
   2 errors generated.
--
   In file included from drivers/gpu/drm/i915/pxp/intel_pxp_tee.c:11:
>> drivers/gpu/drm/i915/i915_drv.h:1756:1: error: all paths through this function will call itself [-Werror,-Winfinite-recursion]
   {
   ^
>> drivers/gpu/drm/i915/pxp/intel_pxp_tee.c:19:35: error: no member named 'gt' in 'struct drm_i915_private'
           return &kdev_to_i915(i915_kdev)->gt.pxp;
                   ~~~~~~~~~~~~~~~~~~~~~~~  ^
   2 errors generated.
--
   In file included from drivers/gpu/drm/i915/selftests/igt_reset.c:12:
>> drivers/gpu/drm/i915/selftests/../i915_drv.h:1756:1: error: all paths through this function will call itself [-Werror,-Winfinite-recursion]
   {
   ^
   1 error generated.


vim +1756 drivers/gpu/drm/i915/i915_drv.h

  1750	
  1751	/* Only valid when HAS_DISPLAY() is true */
  1752	#define INTEL_DISPLAY_ENABLED(dev_priv) \
  1753		(drm_WARN_ON(&(dev_priv)->drm, !HAS_DISPLAY(dev_priv)), !(dev_priv)->params.disable_display)
  1754	
  1755	static inline struct intel_gt *to_root_gt(struct drm_i915_private *i915)
> 1756	{
  1757		return to_root_gt(i915);
  1758	}
  1759	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35255 bytes --]