From: Matthew Auld <matthew.auld@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
adrian.larumbe@collabora.com, dri-devel@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v2 4/8] drm/i915/migrate: fix offset calculation
Date: Fri, 3 Dec 2021 12:24:22 +0000 [thread overview]
Message-ID: <20211203122426.2859679-5-matthew.auld@intel.com> (raw)
In-Reply-To: <20211203122426.2859679-1-matthew.auld@intel.com>
Ensure we add the engine base only after we calculate the qword offset
into the PTE window.
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Ramalingam C <ramalingam.c@intel.com>
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
index d553b76b1168..cb0bb3b94644 100644
--- a/drivers/gpu/drm/i915/gt/intel_migrate.c
+++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
@@ -284,10 +284,10 @@ static int emit_pte(struct i915_request *rq,
GEM_BUG_ON(GRAPHICS_VER(rq->engine->i915) < 8);
/* Compute the page directory offset for the target address range */
- offset += (u64)rq->engine->instance << 32;
offset >>= 12;
offset *= sizeof(u64);
offset += 2 * CHUNK_SZ;
+ offset += (u64)rq->engine->instance << 32;
cs = intel_ring_begin(rq, 6);
if (IS_ERR(cs))
--
2.31.1
next prev parent reply other threads:[~2021-12-03 12:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 12:24 [Intel-gfx] [PATCH v2 0/8] DG2 accelerated migration/clearing support Matthew Auld
2021-12-03 12:24 ` [Intel-gfx] [PATCH v2 1/8] drm/i915/migrate: don't check the scratch page Matthew Auld
2021-12-03 16:38 ` Ramalingam C
2021-12-03 12:24 ` [Intel-gfx] [PATCH v2 2/8] drm/i915/gtt: add xehpsdv_ppgtt_insert_entry Matthew Auld
2021-12-03 16:59 ` Ramalingam C
2021-12-03 17:31 ` Matthew Auld
2021-12-03 17:45 ` Ramalingam C
2021-12-03 12:24 ` [Intel-gfx] [PATCH v2 3/8] drm/i915/gtt: add gtt mappable plumbing Matthew Auld
2021-12-03 17:25 ` Ramalingam C
2021-12-03 17:38 ` Matthew Auld
2021-12-03 12:24 ` Matthew Auld [this message]
2021-12-03 17:30 ` [Intel-gfx] [PATCH v2 4/8] drm/i915/migrate: fix offset calculation Ramalingam C
2021-12-03 17:39 ` Matthew Auld
2021-12-03 12:24 ` [Intel-gfx] [PATCH v2 5/8] drm/i915/migrate: fix length calculation Matthew Auld
2021-12-03 17:36 ` Ramalingam C
2021-12-03 12:24 ` [Intel-gfx] [PATCH v2 6/8] drm/i915/selftests: handle object rounding Matthew Auld
2021-12-03 17:40 ` Ramalingam C
2021-12-03 12:24 ` [Intel-gfx] [PATCH v2 7/8] drm/i915/migrate: add acceleration support for DG2 Matthew Auld
2021-12-03 12:24 ` [Intel-gfx] [PATCH v2 8/8] drm/i915/migrate: turn on acceleration " Matthew Auld
2021-12-03 14:40 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for DG2 accelerated migration/clearing support Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211203122426.2859679-5-matthew.auld@intel.com \
--to=matthew.auld@intel.com \
--cc=adrian.larumbe@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox