Re: [Intel-gfx] [PATCH] drm/i915/selftests: Follow up on increase timeout in i915_gem_contexts selftests

[Matthew Brost <matthew.brost@intel.com>]

On Fri, Dec 03, 2021 at 03:53:56PM -0800, Matthew Brost wrote:
> On Fri, Dec 03, 2021 at 03:30:57PM -0800, Bruce Chang wrote:
> > Follow up on patch https://patchwork.freedesktop.org/patch/446832/
> > 
> > Different platforms will take a bit longer while GuC is enabled, so
> > increase the timeout and also add some margin in i915_gem_context
> > selftest.
> > 
> > Signed-off-by: Bruce Chang <yu.bruce.chang@intel.com>
> > Cc: Matthew Brost <matthew.brost@intel.com>
> > Cc: John Harrison <John.C.Harrison@Intel.com>
> > ---
> >  drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> > index b32f7fed2d9c..ae33e8c705da 100644
> > --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> > +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> > @@ -88,7 +88,7 @@ static int live_nop_switch(void *arg)
> >  			rq = i915_request_get(this);
> >  			i915_request_add(this);
> >  		}
> > -		if (i915_request_wait(rq, 0, HZ) < 0) {
> > +		if (i915_request_wait(rq, 0, 10*HZ) < 0) {
> 
> s/10*HZ/10 * HZ/
> 
> With that and an agreed upon audit of selftests / IGTs:
> Reviewed-by: Matthew Brost <matthew.brost@intel.com
> 
> s/10*HZ/10 * HZ/
> 
> With that and an agreed upon audit of selftests / IGTs:
> Reviewed-by: Matthew Brost <matthew.brost@intel.com
> 
> s/10*HZ/10 * HZ/
> 
> With that and an agreed upon audit of selftests / IGTs:
> Reviewed-by: Matthew Brost <matthew.brost@intel.com
> 
> s/10*HZ/10 * HZ/
> 
> With that and an agreed upon audit of selftests / IGTs:
> Reviewed-by: Matthew Brost <matthew.brost@intel.com
> 
> s/10*HZ/10 * HZ/
> 
> With that and an agreed upon audit of selftests / IGTs:
> Reviewed-by: Matthew Brost <matthew.brost@intel.com
> 
> s/10*HZ/10 * HZ/
> 
> With that and an agreed upon audit of selftests / IGTs:
> Reviewed-by: Matthew Brost <matthew.brost@intel.com
> 
> s/10*HZ/10 * HZ/
> 
> With that and an agreed upon audit of selftests / IGTs:
> Reviewed-by: Matthew Brost <matthew.brost@intel.com
> 
> s/10*HZ/10 * HZ/
> 
> With that and an agreed upon audit of selftests / IGTs:
> Reviewed-by: Matthew Brost <matthew.brost@intel.com
> 
> s/10*HZ/10 * HZ/
> 
> With that and an agreed upon audit of selftests / IGTs:
> Reviewed-by: Matthew Brost <matthew.brost@intel.com>
> 

^^^ Copy paste malfunction....

> >  			pr_err("Failed to populated %d contexts\n", nctx);
> >  			intel_gt_set_wedged(&i915->gt);
> >  			i915_request_put(rq);
> > -- 
> > 2.21.3
> >