public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: ira.weiny@intel.com
To: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Patrik Jakobsson <patrik.r.jakobsson@gmail.com>,
	Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>
Cc: linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org, Ira Weiny <ira.weiny@intel.com>
Subject: [Intel-gfx] [PATCH 4/7] drm/radeon: Replace kmap() with kmap_local_page()
Date: Fri, 10 Dec 2021 15:24:01 -0800	[thread overview]
Message-ID: <20211210232404.4098157-5-ira.weiny@intel.com> (raw)
In-Reply-To: <20211210232404.4098157-1-ira.weiny@intel.com>

From: Ira Weiny <ira.weiny@intel.com>

kmap() is being deprecated and this usage is local to the thread.  Use
kmap_local_page() instead.

Signed-off-by: Ira Weiny <ira.weiny@intel.com>
---
 drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
index 11b21d605584..76d7906e1785 100644
--- a/drivers/gpu/drm/radeon/radeon_ttm.c
+++ b/drivers/gpu/drm/radeon/radeon_ttm.c
@@ -907,11 +907,11 @@ static ssize_t radeon_ttm_gtt_read(struct file *f, char __user *buf,
 
 		page = rdev->gart.pages[p];
 		if (page) {
-			ptr = kmap(page);
+			ptr = kmap_local_page(page);
 			ptr += off;
 
 			r = copy_to_user(buf, ptr, cur_size);
-			kunmap(rdev->gart.pages[p]);
+			kunmap_local(ptr);
 		} else
 			r = clear_user(buf, cur_size);
 
-- 
2.31.1


  parent reply	other threads:[~2021-12-10 23:24 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-10 23:23 [Intel-gfx] [PATCH 0/7] DRM kmap() fixes and kmap_local_page() conversions ira.weiny
2021-12-10 23:23 ` [Intel-gfx] [PATCH 1/7] drm/i915: Replace kmap() with kmap_local_page() ira.weiny
2021-12-13  9:04   ` Christoph Hellwig
2021-12-13 16:02     ` Ira Weiny
2021-12-13 12:39   ` Ville Syrjälä
2021-12-13 15:45     ` Ira Weiny
2021-12-22  6:08   ` [Intel-gfx] [PATCH V2] " ira.weiny
2021-12-10 23:23 ` [Intel-gfx] [PATCH 2/7] drm/amd: " ira.weiny
2021-12-10 23:24 ` [Intel-gfx] [PATCH 3/7] drm/gma: Remove calls to kmap() ira.weiny
2021-12-10 23:24 ` ira.weiny [this message]
2021-12-10 23:24 ` [Intel-gfx] [PATCH 5/7] drm/msm: Alter comment to use kmap_local_page() ira.weiny
2021-12-10 23:24 ` [Intel-gfx] [PATCH 6/7] drm/amdgpu: Ensure kunmap is called on error ira.weiny
2021-12-13 20:37   ` Christian König
2021-12-14  3:37     ` Ira Weiny
2021-12-14  7:09       ` Christian König
2021-12-15 21:09         ` Ira Weiny
2021-12-16  8:32           ` Christian König
2021-12-10 23:24 ` [Intel-gfx] [PATCH 7/7] drm/radeon: " ira.weiny
2021-12-10 23:36 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for DRM kmap() fixes and kmap_local_page() conversions Patchwork
2021-12-13 19:13 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for DRM kmap() fixes and kmap_local_page() conversions (rev2) Patchwork
2021-12-22  6:12 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for DRM kmap() fixes and kmap_local_page() conversions (rev3) Patchwork
2022-01-19 16:53 ` [Intel-gfx] [PATCH 0/7] DRM kmap() fixes and kmap_local_page() conversions Ira Weiny
2022-01-19 17:24   ` Daniel Vetter
2022-01-19 23:55     ` Ira Weiny
2022-01-20  8:16       ` Christian König
2022-01-20 15:48         ` Daniel Vetter
2022-01-20 16:57           ` Ira Weiny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211210232404.4098157-5-ira.weiny@intel.com \
    --to=ira.weiny@intel.com \
    --cc=airlied@linux.ie \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patrik.r.jakobsson@gmail.com \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox