From: Manasi Navare <manasi.d.navare@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH] drm/i915/display/vrr: Reset VRR capable property on a long hpd
Date: Wed, 12 Jan 2022 11:57:22 -0800 [thread overview]
Message-ID: <20220112195722.16639-1-manasi.d.navare@intel.com> (raw)
With some VRR panels, user can turn VRR ON/OFF on the fly from the panel settings.
When VRR is turned OFF ,sends a long HPD to the driver clearing the Ignore MSA bit
in the DPCD. Currently the driver parses that onevery HPD but fails to reset
the corresponding VRR Capable Connector property.
Hence the userspace still sees this as VRR Capable panel which is incorrect.
Fix this by explicitly resetting the connector property.
Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index df2a7d86aef0..4f1418f02b76 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -4539,15 +4539,24 @@ static int intel_dp_get_modes(struct drm_connector *connector)
{
struct intel_connector *intel_connector = to_intel_connector(connector);
struct edid *edid;
+ struct drm_i915_private *dev_priv = to_i915(connector->dev);
int num_modes = 0;
edid = intel_connector->detect_edid;
if (edid) {
num_modes = intel_connector_update_modes(connector, edid);
- if (intel_vrr_is_capable(connector))
+ if (intel_vrr_is_capable(connector)) {
+ drm_dbg_kms(&dev_priv->drm, "VRR capable = TRUE for [CONNECTOR:%d:%s]\n",
+ connector->base.id, connector->name);
drm_connector_set_vrr_capable_property(connector,
true);
+ } else {
+ drm_dbg_kms(&dev_priv->drm, "VRR capable = false for [CONNECTOR:%d:%s]\n",
+ connector->base.id, connector->name);
+ drm_connector_set_vrr_capable_property(connector,
+ false);
+ }
}
/* Also add fixed mode, which may or may not be present in EDID */
--
2.19.1
next reply other threads:[~2022-01-12 19:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 19:57 Manasi Navare [this message]
2022-01-12 20:06 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display/vrr: Reset VRR capable property on a long hpd Patchwork
2022-01-12 20:37 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-01-14 12:33 ` [Intel-gfx] [PATCH] " Jani Nikula
2022-01-26 18:32 ` Navare, Manasi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220112195722.16639-1-manasi.d.navare@intel.com \
--to=manasi.d.navare@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox