From: Andrzej Hajda <andrzej.hajda@intel.com>
To: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, netdev <netdev@vger.kernel.org>
Cc: Marco Elver <elver@google.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Lucas De Marchi <lucas.demarchi@intel.com>,
Chris Wilson <chris.p.wilson@intel.com>,
Eric Dumazet <edumazet@google.com>,
Alexander Potapenko <glider@google.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Dmitry Vyukov <dvyukov@google.com>
Subject: [Intel-gfx] [PATCH v2 03/11] [DO NOT MERGE] ref_tracker: remove filter_irq_stacks() call
Date: Tue, 22 Feb 2022 00:16:49 +0100 [thread overview]
Message-ID: <20220221231705.1481059-8-andrzej.hajda@intel.com> (raw)
In-Reply-To: <20220221231705.1481059-1-andrzej.hajda@intel.com>
From: Eric Dumazet <edumazet@google.com>
After commit e94006608949 ("lib/stackdepot: always do filter_irq_stacks()
in stack_depot_save()") it became unnecessary to filter the stack
before calling stack_depot_save().
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Marco Elver <elver@google.com>
Cc: Alexander Potapenko <glider@google.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
lib/ref_tracker.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/ref_tracker.c b/lib/ref_tracker.c
index 9c0c2e09df666..dc7b14aa3431e 100644
--- a/lib/ref_tracker.c
+++ b/lib/ref_tracker.c
@@ -89,7 +89,6 @@ int ref_tracker_alloc(struct ref_tracker_dir *dir,
return -ENOMEM;
}
nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 1);
- nr_entries = filter_irq_stacks(entries, nr_entries);
tracker->alloc_stack_handle = stack_depot_save(entries, nr_entries, gfp);
spin_lock_irqsave(&dir->lock, flags);
@@ -120,7 +119,6 @@ int ref_tracker_free(struct ref_tracker_dir *dir,
return -EEXIST;
}
nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 1);
- nr_entries = filter_irq_stacks(entries, nr_entries);
stack_handle = stack_depot_save(entries, nr_entries, GFP_ATOMIC);
spin_lock_irqsave(&dir->lock, flags);
--
2.25.1
next prev parent reply other threads:[~2022-02-21 23:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 23:16 [Intel-gfx] [PATCH v2 00/11] drm/i915: use ref_tracker library for tracking wakerefs Andrzej Hajda
2022-02-21 23:16 ` [Intel-gfx] [PATCH v2 01/11] [DO NOT MERGE] ref_tracker: implement use-after-free detection Andrzej Hajda
2022-02-21 23:16 ` [Intel-gfx] [PATCH v2 1/9] lib/ref_tracker: add unlocked leak print helper Andrzej Hajda
2022-02-21 23:16 ` [Intel-gfx] [PATCH v2 01/11] ref_tracker: implement use-after-free detection Andrzej Hajda
2022-02-21 23:16 ` [Intel-gfx] [PATCH v2 02/11] [DO NOT MERGE] ref_tracker: add a count of untracked references Andrzej Hajda
2022-02-21 23:16 ` [Intel-gfx] [PATCH v2 2/9] lib/ref_tracker: compact stacktraces before printing Andrzej Hajda
2022-02-21 23:16 ` [Intel-gfx] [PATCH v2 02/11] ref_tracker: add a count of untracked references Andrzej Hajda
2022-02-21 23:16 ` Andrzej Hajda [this message]
2022-02-21 23:16 ` [Intel-gfx] [PATCH v2 3/9] lib/ref_tracker: __ref_tracker_dir_print improve printing Andrzej Hajda
2022-02-21 23:16 ` [Intel-gfx] [PATCH v2 03/11] ref_tracker: remove filter_irq_stacks() call Andrzej Hajda
2022-02-21 23:16 ` [Intel-gfx] [PATCH v2 4/9] lib/ref_tracker: add printing to memory buffer Andrzej Hajda
2022-02-21 23:16 ` [Intel-gfx] [PATCH v2 04/11] lib/ref_tracker: add unlocked leak print helper Andrzej Hajda
2022-02-21 23:16 ` [Intel-gfx] [PATCH v2 5/9] lib/ref_tracker: improve allocation flags Andrzej Hajda
2022-02-21 23:16 ` [Intel-gfx] [PATCH v2 05/11] lib/ref_tracker: __ref_tracker_dir_print improve printing Andrzej Hajda
2022-02-21 23:16 ` [Intel-gfx] [PATCH v2 6/9] drm/i915: Separate wakeref tracking Andrzej Hajda
2022-02-21 23:16 ` [Intel-gfx] [PATCH v2 06/11] lib/ref_tracker: add printing to memory buffer Andrzej Hajda
2022-02-21 23:16 ` [Intel-gfx] [PATCH v2 7/9] drm/i915: Track leaked gt->wakerefs Andrzej Hajda
2022-02-21 23:16 ` [Intel-gfx] [PATCH v2 07/11] lib/ref_tracker: remove warnings in case of allocation failure Andrzej Hajda
2022-02-21 23:17 ` [Intel-gfx] [PATCH v2 8/9] drm/i915: Correct type of wakeref variable Andrzej Hajda
2022-02-21 23:17 ` [Intel-gfx] [PATCH v2 08/11] drm/i915: Separate wakeref tracking Andrzej Hajda
2022-02-21 23:17 ` [Intel-gfx] [PATCH v2 9/9] drm/i915: replace Intel internal tracker with kernel core ref_tracker Andrzej Hajda
2022-02-21 23:17 ` [Intel-gfx] [PATCH v2 09/11] drm/i915: Track leaked gt->wakerefs Andrzej Hajda
2022-02-21 23:17 ` [Intel-gfx] [PATCH v2 10/11] drm/i915: Correct type of wakeref variable Andrzej Hajda
2022-02-21 23:17 ` [Intel-gfx] [PATCH v2 11/11] drm/i915: replace Intel internal tracker with kernel core ref_tracker Andrzej Hajda
2022-02-21 23:23 ` [Intel-gfx] [PATCH v2 00/11] drm/i915: use ref_tracker library for tracking wakerefs Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220221231705.1481059-8-andrzej.hajda@intel.com \
--to=andrzej.hajda@intel.com \
--cc=chris.p.wilson@intel.com \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox