public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.auld@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: [Intel-gfx] [CI 6/7] drm/i915/buddy: tweak 2big check
Date: Fri, 25 Feb 2022 14:55:01 +0000	[thread overview]
Message-ID: <20220225145502.331818-6-matthew.auld@intel.com> (raw)
In-Reply-To: <20220225145502.331818-1-matthew.auld@intel.com>

Otherwise we get -EINVAL, instead of the more useful -E2BIG if the
allocation doesn't fit within the pfn range, like with mappable lmem.
The hugepages selftest, for example, needs this to know if a smaller
size is needed.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Acked-by: Nirmoy Das <nirmoy.das@intel.com>
---
 drivers/gpu/drm/i915/i915_ttm_buddy_manager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_ttm_buddy_manager.c b/drivers/gpu/drm/i915/i915_ttm_buddy_manager.c
index 0ac6b2463fd5..92d49a3c378c 100644
--- a/drivers/gpu/drm/i915/i915_ttm_buddy_manager.c
+++ b/drivers/gpu/drm/i915/i915_ttm_buddy_manager.c
@@ -82,7 +82,7 @@ static int i915_ttm_buddy_man_alloc(struct ttm_resource_manager *man,
 			lpfn = pages;
 	}
 
-	if (size > mm->size) {
+	if (size > lpfn << PAGE_SHIFT) {
 		err = -E2BIG;
 		goto err_free_res;
 	}
-- 
2.34.1


  parent reply	other threads:[~2022-02-25 14:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-25 14:54 [Intel-gfx] [CI 1/7] drm/i915: add io_size plumbing Matthew Auld
2022-02-25 14:54 ` [Intel-gfx] [CI 2/7] drm/i915/ttm: require mappable by default Matthew Auld
2022-02-25 14:54 ` [Intel-gfx] [CI 3/7] drm/i915: add I915_BO_ALLOC_GPU_ONLY Matthew Auld
2022-02-25 14:54 ` [Intel-gfx] [CI 4/7] drm/i915/buddy: track available visible size Matthew Auld
2022-02-25 14:55 ` [Intel-gfx] [CI 5/7] drm/i915/buddy: adjust res->start Matthew Auld
2022-02-25 14:55 ` Matthew Auld [this message]
2022-02-25 14:55 ` [Intel-gfx] [CI 7/7] drm/i915/selftests: mock test io_size Matthew Auld
2022-02-25 22:13 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/7] drm/i915: add io_size plumbing Patchwork
2022-02-25 22:15 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-02-25 22:43 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-02-26 21:48 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220225145502.331818-6-matthew.auld@intel.com \
    --to=matthew.auld@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox