Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Cheng <michael.cheng@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: thomas.hellstrom@linux.intel.com, michael.cheng@intel.com,
	daniel.vetter@ffwll.ch, lucas.demarchi@intel.com,
	dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk
Subject: [Intel-gfx] [PATCH 3/4] i915/gem: Revert i915_gem_freeze to previous logic
Date: Sat, 19 Mar 2022 12:42:26 -0700	[thread overview]
Message-ID: <20220319194227.297639-4-michael.cheng@intel.com> (raw)
In-Reply-To: <20220319194227.297639-1-michael.cheng@intel.com>

This patch reverts i915_gem_freeze to previous logic [1] to avoid using
wbinvd_on_all_cpus.

[1]. https://patchwork.freedesktop.org/patch/415007/?series=86058&rev=2

Suggested-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Michael Cheng <michael.cheng@intel.com>
---
 drivers/gpu/drm/i915/gem/i915_gem_pm.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pm.c b/drivers/gpu/drm/i915/gem/i915_gem_pm.c
index 3f20961bb59b..f78f2f004d6c 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_pm.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_pm.c
@@ -212,13 +212,18 @@ int i915_gem_freeze_late(struct drm_i915_private *i915)
 	 * the objects as well, see i915_gem_freeze()
 	 */
 
-	with_intel_runtime_pm(&i915->runtime_pm, wakeref)
-		i915_gem_shrink(NULL, i915, -1UL, NULL, ~0);
+	wakeref = intel_runtime_pm_get(&i915->runtime_pm);
+	i915_gem_shrink(NULL, i915, -1UL, NULL, ~0);
 	i915_gem_drain_freed_objects(i915);
 
-	wbinvd_on_all_cpus();
-	list_for_each_entry(obj, &i915->mm.shrink_list, mm.link)
-		__start_cpu_write(obj);
+	list_for_each_entry(obj, &i915->mm.shrink_list, mm.link) {
+		i915_gem_object_lock(obj, NULL);
+		drm_WARN_ON(&i915->drm,
+			i915_gem_object_set_to_cpu_domain(obj, true));
+		i915_gem_object_unlock(obj);
+	}
+
+	intel_runtime_pm_put(&i915->runtime_pm, wakeref);
 
 	return 0;
 }
-- 
2.25.1


  parent reply	other threads:[~2022-03-19 19:42 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-19 19:42 [Intel-gfx] [PATCH 0/4] Drop wbinvd_on_all_cpus usage Michael Cheng
2022-03-19 19:42 ` [Intel-gfx] [PATCH 1/4] i915/gem: drop " Michael Cheng
2022-03-21 10:30   ` Tvrtko Ursulin
2022-03-21 11:07     ` Thomas Hellström
2022-03-21 18:51       ` Michael Cheng
2022-03-21 16:31     ` Michael Cheng
2022-03-21 17:28       ` Tvrtko Ursulin
2022-03-21 17:42         ` Michael Cheng
2022-03-22 14:35           ` Daniel Vetter
2022-03-21 17:51         ` Michael Cheng
2022-03-19 19:42 ` [Intel-gfx] [PATCH 2/4] Revert "drm/i915/gem: Almagamate clflushes on suspend" Michael Cheng
2022-03-19 19:42 ` Michael Cheng [this message]
2022-03-19 19:42 ` [Intel-gfx] [PATCH 4/4] drm/i915/gt: Revert ggtt_resume to previous logic Michael Cheng
2022-03-19 20:15 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Drop wbinvd_on_all_cpus usage Patchwork
2022-03-19 20:16 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-03-19 20:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-03-19 22:04 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-03-21 10:27 ` [Intel-gfx] [PATCH 0/4] " Tvrtko Ursulin
2022-03-21 11:03   ` Thomas Hellström
2022-03-21 12:22     ` Tvrtko Ursulin
2022-03-21 12:33       ` Thomas Hellström
2022-03-21 13:12         ` Tvrtko Ursulin
2022-03-21 13:40           ` Thomas Hellström
2022-03-21 14:43             ` Tvrtko Ursulin
2022-03-21 15:15               ` Thomas Hellström
2022-03-22 10:13                 ` Tvrtko Ursulin
2022-03-22 10:26                   ` Thomas Hellström
2022-03-22 10:41                     ` Thomas Hellström
2022-03-22 11:20                     ` Tvrtko Ursulin
2022-03-22 11:37                       ` Thomas Hellström
2022-03-22 12:53                         ` Tvrtko Ursulin
2022-03-22 15:07                           ` Thomas Hellström

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220319194227.297639-4-michael.cheng@intel.com \
    --to=michael.cheng@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox