From: Ramalingam C <ramalingam.c@intel.com>
To: "Das, Nirmoy" <nirmoy.das@linux.intel.com>
Cc: Thomas Hellstrom <thomas.hellstrom@linux.intel.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Hellstrom Thomas <thomas.hellstrom@intel.com>,
Matthew Auld <matthew.auld@intel.com>,
Christian Koenig <christian.koenig@amd.com>
Subject: Re: [Intel-gfx] [PATCH v4 6/8] drm/ttm: Add a parameter to add extra pages into ttm_tt
Date: Tue, 22 Mar 2022 04:36:30 +0530 [thread overview]
Message-ID: <20220321230630.GC12356@intel.com> (raw)
In-Reply-To: <f461eb40-2ae9-72f0-56a2-b06acc20f5c9@linux.intel.com>
On 2022-03-21 at 11:11:33 +0100, Das, Nirmoy wrote:
> In the previous version I replied only to the mailing list email so probably
> my email slipped through.
Sorry for the miss. Thank so much for the review.
Ram
>
> Reviewed-by: Nirmoy Das <nirmoy.das@intel.com> for patch 6-7
>
> On 3/19/2022 9:42 PM, Ramalingam C wrote:
> > Add a parameter called "extra_pages" for ttm_tt_init, to indicate that
> > driver needs extra pages in ttm_tt.
> >
> > v2:
> > Used imperative wording [Thomas and Christian]
> >
> > Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> > cc: Christian Koenig <christian.koenig@amd.com>
> > cc: Hellstrom Thomas <thomas.hellstrom@intel.com>
> > Reviewed-by: Thomas Hellstrom <thomas.hellstrom@linux.intel.com>
> > Reviewed-by: Christian Konig <christian.koenig@amd.com>
> > ---
> > drivers/gpu/drm/drm_gem_vram_helper.c | 2 +-
> > drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +-
> > drivers/gpu/drm/qxl/qxl_ttm.c | 2 +-
> > drivers/gpu/drm/ttm/ttm_agp_backend.c | 2 +-
> > drivers/gpu/drm/ttm/ttm_tt.c | 12 +++++++-----
> > drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 2 +-
> > include/drm/ttm/ttm_tt.h | 4 +++-
> > 7 files changed, 15 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c
> > index dc7f938bfff2..123045b58fec 100644
> > --- a/drivers/gpu/drm/drm_gem_vram_helper.c
> > +++ b/drivers/gpu/drm/drm_gem_vram_helper.c
> > @@ -867,7 +867,7 @@ static struct ttm_tt *bo_driver_ttm_tt_create(struct ttm_buffer_object *bo,
> > if (!tt)
> > return NULL;
> > - ret = ttm_tt_init(tt, bo, page_flags, ttm_cached);
> > + ret = ttm_tt_init(tt, bo, page_flags, ttm_cached, 0);
> > if (ret < 0)
> > goto err_ttm_tt_init;
> > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> > index e4a06fcf741a..3b9f99c765c4 100644
> > --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> > +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> > @@ -290,7 +290,7 @@ static struct ttm_tt *i915_ttm_tt_create(struct ttm_buffer_object *bo,
> > i915_tt->is_shmem = true;
> > }
> > - ret = ttm_tt_init(&i915_tt->ttm, bo, page_flags, caching);
> > + ret = ttm_tt_init(&i915_tt->ttm, bo, page_flags, caching, 0);
> > if (ret)
> > goto err_free;
> > diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c
> > index b2e33d5ba5d0..52156b54498f 100644
> > --- a/drivers/gpu/drm/qxl/qxl_ttm.c
> > +++ b/drivers/gpu/drm/qxl/qxl_ttm.c
> > @@ -113,7 +113,7 @@ static struct ttm_tt *qxl_ttm_tt_create(struct ttm_buffer_object *bo,
> > ttm = kzalloc(sizeof(struct ttm_tt), GFP_KERNEL);
> > if (ttm == NULL)
> > return NULL;
> > - if (ttm_tt_init(ttm, bo, page_flags, ttm_cached)) {
> > + if (ttm_tt_init(ttm, bo, page_flags, ttm_cached, 0)) {
> > kfree(ttm);
> > return NULL;
> > }
> > diff --git a/drivers/gpu/drm/ttm/ttm_agp_backend.c b/drivers/gpu/drm/ttm/ttm_agp_backend.c
> > index 6ddc16f0fe2b..d27691f2e451 100644
> > --- a/drivers/gpu/drm/ttm/ttm_agp_backend.c
> > +++ b/drivers/gpu/drm/ttm/ttm_agp_backend.c
> > @@ -134,7 +134,7 @@ struct ttm_tt *ttm_agp_tt_create(struct ttm_buffer_object *bo,
> > agp_be->mem = NULL;
> > agp_be->bridge = bridge;
> > - if (ttm_tt_init(&agp_be->ttm, bo, page_flags, ttm_write_combined)) {
> > + if (ttm_tt_init(&agp_be->ttm, bo, page_flags, ttm_write_combined, 0)) {
> > kfree(agp_be);
> > return NULL;
> > }
> > diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c
> > index d234aab800a0..1a66d9fc589a 100644
> > --- a/drivers/gpu/drm/ttm/ttm_tt.c
> > +++ b/drivers/gpu/drm/ttm/ttm_tt.c
> > @@ -134,9 +134,10 @@ void ttm_tt_destroy(struct ttm_device *bdev, struct ttm_tt *ttm)
> > static void ttm_tt_init_fields(struct ttm_tt *ttm,
> > struct ttm_buffer_object *bo,
> > uint32_t page_flags,
> > - enum ttm_caching caching)
> > + enum ttm_caching caching,
> > + unsigned long extra_pages)
> > {
> > - ttm->num_pages = PAGE_ALIGN(bo->base.size) >> PAGE_SHIFT;
> > + ttm->num_pages = (PAGE_ALIGN(bo->base.size) >> PAGE_SHIFT) + extra_pages;
> > ttm->caching = ttm_cached;
> > ttm->page_flags = page_flags;
> > ttm->dma_address = NULL;
> > @@ -146,9 +147,10 @@ static void ttm_tt_init_fields(struct ttm_tt *ttm,
> > }
> > int ttm_tt_init(struct ttm_tt *ttm, struct ttm_buffer_object *bo,
> > - uint32_t page_flags, enum ttm_caching caching)
> > + uint32_t page_flags, enum ttm_caching caching,
> > + unsigned long extra_pages)
> > {
> > - ttm_tt_init_fields(ttm, bo, page_flags, caching);
> > + ttm_tt_init_fields(ttm, bo, page_flags, caching, extra_pages);
> > if (ttm_tt_alloc_page_directory(ttm)) {
> > pr_err("Failed allocating page table\n");
> > @@ -180,7 +182,7 @@ int ttm_sg_tt_init(struct ttm_tt *ttm, struct ttm_buffer_object *bo,
> > {
> > int ret;
> > - ttm_tt_init_fields(ttm, bo, page_flags, caching);
> > + ttm_tt_init_fields(ttm, bo, page_flags, caching, 0);
> > if (page_flags & TTM_TT_FLAG_EXTERNAL)
> > ret = ttm_sg_tt_alloc_page_directory(ttm);
> > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
> > index b84ecc6d6611..4e3938e62c08 100644
> > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
> > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
> > @@ -517,7 +517,7 @@ static struct ttm_tt *vmw_ttm_tt_create(struct ttm_buffer_object *bo,
> > ttm_cached);
> > else
> > ret = ttm_tt_init(&vmw_be->dma_ttm, bo, page_flags,
> > - ttm_cached);
> > + ttm_cached, 0);
> > if (unlikely(ret != 0))
> > goto out_no_init;
> > diff --git a/include/drm/ttm/ttm_tt.h b/include/drm/ttm/ttm_tt.h
> > index f20832139815..17a0310e8aaa 100644
> > --- a/include/drm/ttm/ttm_tt.h
> > +++ b/include/drm/ttm/ttm_tt.h
> > @@ -140,6 +140,7 @@ int ttm_tt_create(struct ttm_buffer_object *bo, bool zero_alloc);
> > * @bo: The buffer object we create the ttm for.
> > * @page_flags: Page flags as identified by TTM_TT_FLAG_XX flags.
> > * @caching: the desired caching state of the pages
> > + * @extra_pages: Extra pages needed for the driver.
> > *
> > * Create a struct ttm_tt to back data with system memory pages.
> > * No pages are actually allocated.
> > @@ -147,7 +148,8 @@ int ttm_tt_create(struct ttm_buffer_object *bo, bool zero_alloc);
> > * NULL: Out of memory.
> > */
> > int ttm_tt_init(struct ttm_tt *ttm, struct ttm_buffer_object *bo,
> > - uint32_t page_flags, enum ttm_caching caching);
> > + uint32_t page_flags, enum ttm_caching caching,
> > + unsigned long extra_pages);
> > int ttm_sg_tt_init(struct ttm_tt *ttm_dma, struct ttm_buffer_object *bo,
> > uint32_t page_flags, enum ttm_caching caching);
next prev parent reply other threads:[~2022-03-21 23:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-19 20:42 [Intel-gfx] [PATCH v4 0/8] drm/i915/ttm: Evict and restore of compressed object Ramalingam C
2022-03-19 20:42 ` [Intel-gfx] [PATCH v4 1/8] drm/i915/gt: Use XY_FASR_COLOR_BLT to clear obj on graphics ver 12+ Ramalingam C
2022-03-21 8:49 ` Hellstrom, Thomas
2022-03-21 23:07 ` Ramalingam C
2022-03-19 20:42 ` [Intel-gfx] [PATCH v4 2/8] drm/i915/gt: Clear compress metadata for Flat-ccs objects Ramalingam C
2022-03-19 20:42 ` [Intel-gfx] [PATCH v4 3/8] drm/i915/selftest_migrate: Consider the possible roundup of size Ramalingam C
2022-03-19 20:42 ` [Intel-gfx] [PATCH v4 4/8] drm/i915/selftest_migrate: Check CCS meta data clear Ramalingam C
2022-03-20 1:39 ` kernel test robot
2022-03-21 10:39 ` Hellstrom, Thomas
2022-03-21 23:05 ` Ramalingam C
2022-03-19 20:42 ` [Intel-gfx] [PATCH v4 5/8] drm/i915/gt: Optimize the migration loop Ramalingam C
2022-03-19 20:42 ` [Intel-gfx] [PATCH v4 6/8] drm/ttm: Add a parameter to add extra pages into ttm_tt Ramalingam C
2022-03-21 10:11 ` Das, Nirmoy
2022-03-21 23:06 ` Ramalingam C [this message]
2022-03-19 20:42 ` [Intel-gfx] [PATCH v4 7/8] drm/i915/gem: Add extra pages in ttm_tt for ccs data Ramalingam C
2022-03-19 20:42 ` [Intel-gfx] [PATCH v4 8/8] drm/i915/migrate: Evict and restore the flatccs capable lmem obj Ramalingam C
2022-03-19 20:50 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/ttm: Evict and restore of compressed object (rev2) Patchwork
2022-03-19 20:52 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-03-19 21:26 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-03-19 21:26 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220321230630.GC12356@intel.com \
--to=ramalingam.c@intel.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=nirmoy.das@linux.intel.com \
--cc=thomas.hellstrom@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox