Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Mark Pearson <markpearson@lenovo.com>, dri-devel@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v3 0/3] Fixes for selective fetch area calculation
Date: Tue, 10 May 2022 21:33:10 +0300	[thread overview]
Message-ID: <20220510183313.1046628-1-jouni.hogander@intel.com> (raw)

Currently selective fetch area calculation ends up as bogus area in
at least following cases:

1. Updated plane is partially or fully outside pipe area
2. Big fb with only part of memory area used for plane

These end up as y1 = 0, y2 = 4 or y2 being outside pipe area. This
patch set addresses these by ensuring update area is within pipe area
or by falling back to full update.

Patch set also adds drm_dbg_once* macros to print out debug message
only once. drm_dbg_once_kms is used to printout debug message when
selective fetch area calculation fails.

v3:
 - Add drm_dbg_once* and use it when sel fetch area calculation fails
 - Move drm_rect_intersect to clip_area_update
v2:
 - Update commit message of first patch
 - Set damaged_area x1 and x2 during initialization

Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: Mika Kahola <mika.kahola@intel.com>
Cc: Mark Pearson <markpearson@lenovo.com>

Jouni Högander (3):
  drm/print: Add drm_debug_once* macros
  drm/i915/psr: Use full update In case of area calculation fails
  drm/i915: Ensure damage clip area is within pipe area

 drivers/gpu/drm/i915/display/intel_psr.c | 36 +++++++++++++++++++-----
 include/drm/drm_print.h                  | 29 +++++++++++++++++++
 2 files changed, 58 insertions(+), 7 deletions(-)

-- 
2.25.1


             reply	other threads:[~2022-05-10 18:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-10 18:33 Jouni Högander [this message]
2022-05-10 18:33 ` [Intel-gfx] [PATCH v3 1/3] drm/print: Add drm_debug_once* macros Jouni Högander
2022-05-10 19:22   ` Souza, Jose
2022-05-10 18:33 ` [Intel-gfx] [PATCH v3 2/3] drm/i915/psr: Use full update In case of area calculation fails Jouni Högander
2022-05-10 18:52   ` Souza, Jose
2022-05-10 18:33 ` [Intel-gfx] [PATCH v3 3/3] drm/i915: Ensure damage clip area is within pipe area Jouni Högander
2022-05-10 18:53   ` Souza, Jose
2022-05-10 19:29 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fixes for selective fetch area calculation (rev3) Patchwork
2022-05-10 19:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-05-10 23:32 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220510183313.1046628-1-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=markpearson@lenovo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox