From: Vivek Kasireddy <vivek.kasireddy@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v1 0/2] drm/i915/tc: Prevent system hang when modesetting disconnected Type-C ports
Date: Mon, 16 May 2022 01:54:00 -0700 [thread overview]
Message-ID: <20220516085402.3591249-1-vivek.kasireddy@intel.com> (raw)
The following two patches try to prevent a system hang when a modeset
is forced by userspace (Weston) on legacy Type-C ports that are
disconnected. This issue was accidentally discovered while trying
to modeset one of the HDMI ports on the TGL based Gigabyte system
(https://www.gigabyte.com/Mini-PcBarebone/GB-BSi3-1115G4-rev-10#ov)
using the following Weston settings (configured via weston.ini):
[output]
name=HDMI-A-3
mode=173.00 1920 2048 2248 2576 1080 1083 1088 1120 -hsync +vsync
force-on=true
Entering the name of the HDMI connector incorrectly above (for example
HDMI-A-3 (disconnected) instead of HDMI-A-2 (connected)) lead to
warnings in the log followed by a system hang. To fix this issue,
the first patch prevents the selection of TBT PLL for legacy Type-C
ports and the second one rejects any attempts to modeset disconnected
Type-C ports.
Cc: Imre Deak <imre.deak@intel.com>
Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Vivek Kasireddy (2):
drm/i915/tc: Don't default disconnected legacy Type-C ports to TBT
mode
drm/i915: Reject the atomic modeset if an associated Type-C port is
disconnected
drivers/gpu/drm/i915/display/intel_atomic.c | 20 ++++++++++++++++++++
drivers/gpu/drm/i915/display/intel_tc.c | 3 ++-
2 files changed, 22 insertions(+), 1 deletion(-)
--
2.35.1
next reply other threads:[~2022-05-16 9:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 8:54 Vivek Kasireddy [this message]
2022-05-16 8:54 ` [Intel-gfx] [PATCH v1 1/2] drm/i915/tc: Don't default disconnected legacy Type-C ports to TBT mode Vivek Kasireddy
2022-05-16 12:08 ` Imre Deak
2022-05-16 8:54 ` [Intel-gfx] [PATCH v1 2/2] drm/i915: Reject the atomic modeset if an associated Type-C port is disconnected Vivek Kasireddy
2022-05-16 9:42 ` Jani Nikula
2022-05-16 9:54 ` Imre Deak
2022-05-18 7:04 ` Kasireddy, Vivek
2022-05-19 11:19 ` Imre Deak
2022-05-20 7:28 ` Kasireddy, Vivek
2022-05-23 11:21 ` Imre Deak
2022-05-24 8:29 ` Kasireddy, Vivek
2022-05-24 16:08 ` Imre Deak
2022-05-26 0:11 ` Kasireddy, Vivek
2022-05-16 11:42 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tc: Prevent system hang when modesetting disconnected Type-C ports Patchwork
2022-05-16 12:04 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220516085402.3591249-1-vivek.kasireddy@intel.com \
--to=vivek.kasireddy@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox