Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: John.C.Harrison@Intel.com
To: IGT-Dev@Lists.FreeDesktop.Org
Cc: Intel-GFX@Lists.FreeDesktop.Org
Subject: [Intel-gfx] [PATCH v6 i-g-t 2/3] tests/i915/query: Add descriptions to existing tests
Date: Tue,  7 Jun 2022 14:17:46 -0700	[thread overview]
Message-ID: <20220607211747.3335656-3-John.C.Harrison@Intel.com> (raw)
In-Reply-To: <20220607211747.3335656-1-John.C.Harrison@Intel.com>

From: John Harrison <John.C.Harrison@Intel.com>

None of the query tests had a description. So make some up.

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
 tests/i915/i915_query.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/tests/i915/i915_query.c b/tests/i915/i915_query.c
index 246a979af72a..6c73f60aedcd 100644
--- a/tests/i915/i915_query.c
+++ b/tests/i915/i915_query.c
@@ -923,34 +923,41 @@ igt_main
 		devid = intel_get_drm_devid(fd);
 	}
 
+	igt_describe("Test response to an invalid query call");
 	igt_subtest("query-garbage")
 		test_query_garbage(fd);
 
+	igt_describe("Test response to invalid DRM_I915_QUERY_TOPOLOGY_INFO query");
 	igt_subtest("query-topology-garbage-items") {
 		igt_require(query_topology_supported(fd));
 		test_query_topology_garbage_items(fd);
 	}
 
+	igt_describe("Guardband test for DRM_I915_QUERY_TOPOLOGY_INFO query");
 	igt_subtest("query-topology-kernel-writes") {
 		igt_require(query_topology_supported(fd));
 		test_query_topology_kernel_writes(fd);
 	}
 
+	igt_describe("Verify DRM_I915_QUERY_TOPOLOGY_INFO query fails when it is not supported");
 	igt_subtest("query-topology-unsupported") {
 		igt_require(!query_topology_supported(fd));
 		test_query_topology_unsupported(fd);
 	}
 
+	igt_describe("Compare new DRM_I915_QUERY_TOPOLOGY_INFO query with legacy (sub)slice getparams");
 	igt_subtest("query-topology-coherent-slice-mask") {
 		igt_require(query_topology_supported(fd));
 		test_query_topology_coherent_slice_mask(fd);
 	}
 
+	igt_describe("More compare new DRM_I915_QUERY_TOPOLOGY_INFO query with legacy (sub)slice getparams");
 	igt_subtest("query-topology-matches-eu-total") {
 		igt_require(query_topology_supported(fd));
 		test_query_topology_matches_eu_total(fd);
 	}
 
+	igt_describe("Verify DRM_I915_QUERY_TOPOLOGY_INFO query against hardcoded known values for certain platforms");
 	igt_subtest("query-topology-known-pci-ids") {
 		igt_require(query_topology_supported(fd));
 		igt_require(IS_HASWELL(devid) || IS_BROADWELL(devid) ||
@@ -959,16 +966,19 @@ igt_main
 		test_query_topology_known_pci_ids(fd, devid);
 	}
 
+	igt_describe("Test DRM_I915_QUERY_GEOMETRY_SUBSLICES query");
 	igt_subtest("test-query-geometry-subslices") {
 		igt_require(query_geometry_subslices_supported(fd));
 		test_query_geometry_subslices(fd);
 	}
 
+	igt_describe("Dodgy returned data tests for DRM_I915_QUERY_MEMORY_REGIONS");
 	igt_subtest("query-regions-garbage-items") {
 		igt_require(query_regions_supported(fd));
 		test_query_regions_garbage_items(fd);
 	}
 
+	igt_describe("Basic tests for DRM_I915_QUERY_MEMORY_REGIONS");
 	igt_subtest("query-regions-sanity-check") {
 		igt_require(query_regions_supported(fd));
 		test_query_regions_sanity_check(fd);
@@ -979,9 +989,11 @@ igt_main
 			igt_require(query_engine_info_supported(fd));
 		}
 
+		igt_describe("Negative tests for DRM_I915_QUERY_ENGINE_INFO");
 		igt_subtest("engine-info-invalid")
 			engines_invalid(fd);
 
+		igt_describe("Positive tests for DRM_I915_QUERY_ENGINE_INFO");
 		igt_subtest("engine-info")
 			engines(fd);
 	}
-- 
2.36.0


  parent reply	other threads:[~2022-06-07 21:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-07 21:17 [Intel-gfx] [PATCH v6 i-g-t 0/3] Update DRM UAPI and add test for new hw info query John.C.Harrison
2022-06-07 21:17 ` [Intel-gfx] [PATCH v6 i-g-t 1/3] include/drm-uapi: Update to latest i915_drm.h John.C.Harrison
2022-06-07 21:17 ` John.C.Harrison [this message]
2022-06-07 21:17 ` [Intel-gfx] [PATCH v6 i-g-t 3/3] tests/i915/query: Query, parse and validate the hwconfig table John.C.Harrison

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220607211747.3335656-3-John.C.Harrison@Intel.com \
    --to=john.c.harrison@intel.com \
    --cc=IGT-Dev@Lists.FreeDesktop.Org \
    --cc=Intel-GFX@Lists.FreeDesktop.Org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox