From: Arun R Murthy <arun.r.murthy@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH i-g-t] tests/kms_async_flips: first async flip discarded on i915
Date: Fri, 10 Jun 2022 13:18:53 +0530 [thread overview]
Message-ID: <20220610074853.3937294-1-arun.r.murthy@intel.com> (raw)
In-Reply-To: <20220608060737.3839351-1-arun.r.murthy@intel.com>
The i915 KMD will use the first async flip to update the watermarks as
per the watermark optimization in DISPLAY13. Hence the actual async flip
will happen from the subsequent flips.
For alternate sync async test, a dummy async flip has to be done to
allow the KMD to perform the watermark related updates before writing to
the surface base address.
Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
tests/kms_async_flips.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
index 4a0527dc..695aea74 100644
--- a/tests/kms_async_flips.c
+++ b/tests/kms_async_flips.c
@@ -211,11 +211,14 @@ static void test_async_flip(data_t *data)
* In older platforms (<= Gen10), async address update bit is double buffered.
* So flip timestamp can be verified only from the second flip.
* The first async flip just enables the async address update.
+ * In platforms greater than DISPLAY13 the first async flip will be discarded
+ * in order to change the watermark levels as per the optimization. Hence the
+ * subsequent async flips will actually do the asynchronous flips.
*/
if (is_i915_device(data->drm_fd)) {
uint32_t devid = intel_get_drm_devid(data->drm_fd);
- if (IS_GEN9(devid) || IS_GEN10(devid)) {
+ if (IS_GEN9(devid) || IS_GEN10(devid) || AT_LEAST_GEN(devid, 12)) {
ret = drmModePageFlip(data->drm_fd, data->crtc_id,
data->bufs[frame % 4].fb_id,
flags, data);
--
2.25.1
next prev parent reply other threads:[~2022-06-10 7:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 6:07 [Intel-gfx] [PATCH] tests/kms_async_flips: first async flip discarded on i915 Arun R Murthy
2022-06-08 6:49 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
2022-06-08 6:56 ` [Intel-gfx] [PATCH] " Arun R Murthy
2022-06-10 6:24 ` [Intel-gfx] [PATCH i-g-t] " Arun R Murthy
2022-06-08 8:17 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for tests/kms_async_flips: first async flip discarded on i915 (rev2) Patchwork
2022-06-08 10:37 ` [Intel-gfx] [PATCH i-g-t] tests/kms_async_flips: first async flip discarded on i915 Arun R Murthy
2022-06-10 7:48 ` Arun R Murthy [this message]
2022-06-10 10:19 ` Karthik B S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220610074853.3937294-1-arun.r.murthy@intel.com \
--to=arun.r.murthy@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox