public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Alexander Usyskin <alexander.usyskin@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
	Tomas Winkler <tomas.winkler@intel.com>,
	Alexander Usyskin <alexander.usyskin@intel.com>,
	Vitaly Lubart <vitaly.lubart@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v5 08/14] mei: bus: export common mkhi definitions into a separate header
Date: Wed,  6 Jul 2022 14:43:39 +0300	[thread overview]
Message-ID: <20220706114345.1128018-9-alexander.usyskin@intel.com> (raw)
In-Reply-To: <20220706114345.1128018-1-alexander.usyskin@intel.com>

From: Vitaly Lubart <vitaly.lubart@intel.com>

Exported common mkhi definitions from bus-fixup.c into a separate
header file mkhi.h for other driver usage.

Signed-off-by: Vitaly Lubart <vitaly.lubart@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
---
 drivers/misc/mei/bus-fixup.c | 32 ++-----------------------
 drivers/misc/mei/mkhi.h      | 45 ++++++++++++++++++++++++++++++++++++
 2 files changed, 47 insertions(+), 30 deletions(-)
 create mode 100644 drivers/misc/mei/mkhi.h

diff --git a/drivers/misc/mei/bus-fixup.c b/drivers/misc/mei/bus-fixup.c
index 24e91a9ea558..190691abddc9 100644
--- a/drivers/misc/mei/bus-fixup.c
+++ b/drivers/misc/mei/bus-fixup.c
@@ -15,6 +15,7 @@
 
 #include "mei_dev.h"
 #include "client.h"
+#include "mkhi.h"
 
 #define MEI_UUID_NFC_INFO UUID_LE(0xd2de1625, 0x382d, 0x417d, \
 			0x48, 0xa4, 0xef, 0xab, 0xba, 0x8a, 0x12, 0x06)
@@ -80,6 +81,7 @@ static void whitelist(struct mei_cl_device *cldev)
 }
 
 #define OSTYPE_LINUX    2
+
 struct mei_os_ver {
 	__le16 build;
 	__le16 reserved1;
@@ -89,20 +91,6 @@ struct mei_os_ver {
 	u8  reserved2;
 } __packed;
 
-#define MKHI_FEATURE_PTT 0x10
-
-struct mkhi_rule_id {
-	__le16 rule_type;
-	u8 feature_id;
-	u8 reserved;
-} __packed;
-
-struct mkhi_fwcaps {
-	struct mkhi_rule_id id;
-	u8 len;
-	u8 data[];
-} __packed;
-
 struct mkhi_fw_ver_block {
 	u16 minor;
 	u8 major;
@@ -115,22 +103,6 @@ struct mkhi_fw_ver {
 	struct mkhi_fw_ver_block ver[MEI_MAX_FW_VER_BLOCKS];
 } __packed;
 
-#define MKHI_FWCAPS_GROUP_ID 0x3
-#define MKHI_FWCAPS_SET_OS_VER_APP_RULE_CMD 6
-#define MKHI_GEN_GROUP_ID 0xFF
-#define MKHI_GEN_GET_FW_VERSION_CMD 0x2
-struct mkhi_msg_hdr {
-	u8  group_id;
-	u8  command;
-	u8  reserved;
-	u8  result;
-} __packed;
-
-struct mkhi_msg {
-	struct mkhi_msg_hdr hdr;
-	u8 data[];
-} __packed;
-
 #define MKHI_OSVER_BUF_LEN (sizeof(struct mkhi_msg_hdr) + \
 			    sizeof(struct mkhi_fwcaps) + \
 			    sizeof(struct mei_os_ver))
diff --git a/drivers/misc/mei/mkhi.h b/drivers/misc/mei/mkhi.h
new file mode 100644
index 000000000000..27a9b476904e
--- /dev/null
+++ b/drivers/misc/mei/mkhi.h
@@ -0,0 +1,45 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2003-2020, Intel Corporation. All rights reserved.
+ * Intel Management Engine Interface (Intel MEI) Linux driver
+ */
+
+#ifndef _MEI_MKHI_H_
+#define _MEI_MKHI_H_
+
+#include "mei_dev.h"
+
+#define MKHI_FEATURE_PTT 0x10
+
+#define MKHI_FWCAPS_GROUP_ID 0x3
+#define MKHI_FWCAPS_SET_OS_VER_APP_RULE_CMD 6
+#define MKHI_GEN_GROUP_ID 0xFF
+#define MKHI_GEN_GET_FW_VERSION_CMD 0x2
+
+#define MCHI_GROUP_ID  0xA
+
+struct mkhi_rule_id {
+	__le16 rule_type;
+	u8 feature_id;
+	u8 reserved;
+} __packed;
+
+struct mkhi_fwcaps {
+	struct mkhi_rule_id id;
+	u8 len;
+	u8 data[];
+} __packed;
+
+struct mkhi_msg_hdr {
+	u8  group_id;
+	u8  command;
+	u8  reserved;
+	u8  result;
+} __packed;
+
+struct mkhi_msg {
+	struct mkhi_msg_hdr hdr;
+	u8 data[];
+} __packed;
+
+#endif /* _MEI_MKHI_H_ */
-- 
2.34.1


  parent reply	other threads:[~2022-07-06 11:44 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-06 11:43 [Intel-gfx] [PATCH v5 00/14] GSC support for XeHP SDV and DG2 platforms Alexander Usyskin
2022-07-06 11:43 ` [Intel-gfx] [PATCH v5 01/14] drm/i915/gsc: skip irq initialization if using polling Alexander Usyskin
2022-07-06 11:43 ` [Intel-gfx] [PATCH v5 02/14] drm/i915/gsc: add slow_fw flag to the mei auxiliary device Alexander Usyskin
2022-07-07 15:21   ` Rodrigo Vivi
2022-07-18 13:47     ` Winkler, Tomas
2022-07-06 11:43 ` [Intel-gfx] [PATCH v5 03/14] drm/i915/gsc: add slow_fw flag to the gsc device definition Alexander Usyskin
2022-07-06 11:43 ` [Intel-gfx] [PATCH v5 04/14] drm/i915/gsc: add GSC XeHP SDV platform definition Alexander Usyskin
2022-07-06 11:43 ` [Intel-gfx] [PATCH v5 05/14] mei: gsc: use polling instead of interrupts Alexander Usyskin
2022-07-06 11:43 ` [Intel-gfx] [PATCH v5 06/14] mei: gsc: wait for reset thread on stop Alexander Usyskin
2022-07-06 11:43 ` [Intel-gfx] [PATCH v5 07/14] mei: extend timeouts on slow devices Alexander Usyskin
2022-07-06 11:43 ` Alexander Usyskin [this message]
2022-07-06 11:43 ` [Intel-gfx] [PATCH v5 09/14] mei: mkhi: add memory ready command Alexander Usyskin
2022-07-06 11:43 ` [Intel-gfx] [PATCH v5 10/14] mei: gsc: setup gsc extended operational memory Alexander Usyskin
2022-07-06 11:43 ` [Intel-gfx] [PATCH v5 11/14] mei: gsc: add transition to PXP mode in resume flow Alexander Usyskin
2022-07-06 11:43 ` [Intel-gfx] [PATCH v5 12/14] mei: debugfs: add pxp mode to devstate in debugfs Alexander Usyskin
2022-07-06 11:43 ` [Intel-gfx] [PATCH v5 13/14] drm/i915/gsc: allocate extended operational memory in LMEM Alexander Usyskin
2022-08-02 17:29   ` [Intel-gfx] [v5, " Teres Alexis, Alan Previn
2022-08-02 18:49     ` Winkler, Tomas
2022-07-06 11:43 ` [Intel-gfx] [PATCH v5 14/14] HAX: drm/i915: force INTEL_MEI_GSC on for CI Alexander Usyskin
2022-07-06 12:03 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GSC support for XeHP SDV and DG2 platforms (rev5) Patchwork
2022-07-06 12:03 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-07-06 12:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-07-06 17:49 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-07-08 13:34 ` [Intel-gfx] [PATCH v5 00/14] GSC support for XeHP SDV and DG2 platforms Greg Kroah-Hartman
2022-07-08 13:57   ` Rodrigo Vivi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220706114345.1128018-9-alexander.usyskin@intel.com \
    --to=alexander.usyskin@intel.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=gregkh@linuxfoundation.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=tomas.winkler@intel.com \
    --cc=tvrtko.ursulin@linux.intel.com \
    --cc=vitaly.lubart@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox