From: Lyude Paul <lyude@redhat.com>
To: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
Karol Herbst <kherbst@redhat.com>,
Jani Nikula <jani.nikula@intel.com>,
open list <linux-kernel@vger.kernel.org>,
David Airlie <airlied@linux.ie>,
Sean Paul <seanpaul@chromium.org>,
Ben Skeggs <bskeggs@redhat.com>, Daniel Vetter <daniel@ffwll.ch>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Dave Airlie <airlied@redhat.com>,
Fernando Ramos <greenfoo@u92.eu>
Subject: [Intel-gfx] [RFC v2 12/18] drm/nouveau/kms: Pull mst state in for all modesets
Date: Mon, 8 Aug 2022 19:51:57 -0400 [thread overview]
Message-ID: <20220808235203.123892-13-lyude@redhat.com> (raw)
In-Reply-To: <20220808235203.123892-1-lyude@redhat.com>
Since we're going to be relying on atomic locking for payloads now (and the
MST mgr needs to track CRTCs), pull in the topology state for all modesets
in nv50_msto_atomic_check().
Signed-off-by: Lyude Paul <lyude@redhat.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c
index 5669c8d747d7..24807aa9da5f 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
@@ -1049,7 +1049,7 @@ nv50_msto_atomic_check(struct drm_encoder *encoder,
if (ret)
return ret;
- if (!crtc_state->mode_changed && !crtc_state->connectors_changed)
+ if (!drm_atomic_crtc_needs_modeset(crtc_state))
return 0;
/*
--
2.37.1
next prev parent reply other threads:[~2022-08-08 23:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 23:51 [Intel-gfx] [RFC v2 00/18] drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only Lyude Paul
2022-08-08 23:51 ` [Intel-gfx] [RFC v2 01/18] drm/amdgpu/dc/mst: Rename dp_mst_stream_allocation(_table) Lyude Paul
2022-08-08 23:51 ` [Intel-gfx] [RFC v2 02/18] drm/amdgpu/dm/mst: Rename get_payload_table() Lyude Paul
2022-08-08 23:51 ` [Intel-gfx] [RFC v2 03/18] drm/display/dp_mst: Rename drm_dp_mst_vcpi_allocation Lyude Paul
2022-08-08 23:51 ` [Intel-gfx] [RFC v2 04/18] drm/display/dp_mst: Call them time slots, not VCPI slots Lyude Paul
2022-08-08 23:51 ` [Intel-gfx] [RFC v2 05/18] drm/display/dp_mst: Fix confusing docs for drm_dp_atomic_release_time_slots() Lyude Paul
2022-08-08 23:51 ` [Intel-gfx] [RFC v2 06/18] drm/display/dp_mst: Add some missing kdocs for atomic MST structs Lyude Paul
2022-08-08 23:51 ` [Intel-gfx] [RFC v2 07/18] drm/display/dp_mst: Add helper for finding payloads in atomic MST state Lyude Paul
2022-08-08 23:51 ` [Intel-gfx] [RFC v2 08/18] drm/display/dp_mst: Add nonblocking helpers for DP MST Lyude Paul
2022-08-08 23:51 ` [Intel-gfx] [RFC v2 09/18] drm/display/dp_mst: Don't open code modeset checks for releasing time slots Lyude Paul
2022-08-08 23:51 ` [Intel-gfx] [RFC v2 10/18] drm/display/dp_mst: Fix modeset tracking in drm_dp_atomic_release_vcpi_slots() Lyude Paul
2022-08-08 23:51 ` [Intel-gfx] [RFC v2 11/18] drm/nouveau/kms: Cache DP encoders in nouveau_connector Lyude Paul
2022-08-08 23:51 ` Lyude Paul [this message]
2022-08-08 23:51 ` [Intel-gfx] [RFC v2 13/18] drm/display/dp_mst: Add helpers for serializing SST <-> MST transitions Lyude Paul
2022-08-09 23:42 ` [Intel-gfx] [RFC v3] " Lyude Paul
2022-08-08 23:51 ` [Intel-gfx] [RFC v2 14/18] drm/display/dp_mst: Drop all ports from topology on CSNs before queueing link address work Lyude Paul
2022-08-08 23:52 ` [Intel-gfx] [RFC v2 15/18] drm/display/dp_mst: Skip releasing payloads if last connected port isn't connected Lyude Paul
2022-08-08 23:52 ` [Intel-gfx] [RFC v2 16/18] drm/display/dp_mst: Maintain time slot allocations when deleting payloads Lyude Paul
2022-08-08 23:52 ` [Intel-gfx] [RFC v2 17/18] drm/radeon: Drop legacy MST support Lyude Paul
2022-08-08 23:52 ` [Intel-gfx] [RFC v2 18/18] drm/display/dp_mst: Move all payload info into the atomic state Lyude Paul
2022-08-09 0:21 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only Patchwork
2022-08-09 0:43 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-08-10 0:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only (rev2) Patchwork
2022-08-10 3:08 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-08-10 20:35 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only (rev3) Patchwork
2022-08-11 9:46 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220808235203.123892-13-lyude@redhat.com \
--to=lyude@redhat.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=greenfoo@u92.eu \
--cc=hverkuil-cisco@xs4all.nl \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=kherbst@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=seanpaul@chromium.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox