From: Lyude Paul <lyude@redhat.com>
To: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: "Ian Chen" <ian.chen@amd.com>,
"Jani Nikula" <jani.nikula@intel.com>,
"Bhawanpreet Lakha" <Bhawanpreet.Lakha@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
"Roman Li" <Roman.Li@amd.com>,
"open list" <linux-kernel@vger.kernel.org>,
"Leo Li" <sunpeng.li@amd.com>, "Fangzhi Zuo" <Jerry.Zuo@amd.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Wayne Lin" <Wayne.Lin@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Colin Ian King" <colin.king@intel.com>,
"Harry Wentland" <harry.wentland@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: [Intel-gfx] [RFC v4 02/17] drm/amdgpu/dm/mst: Rename get_payload_table()
Date: Wed, 17 Aug 2022 15:38:31 -0400 [thread overview]
Message-ID: <20220817193847.557945-3-lyude@redhat.com> (raw)
In-Reply-To: <20220817193847.557945-1-lyude@redhat.com>
This function isn't too confusing if you see the comment around the
call-site for it, but if you don't then it's not at all obvious this is
meant to copy DRM's payload table over to DC's internal state structs.
Seeing this function before finding that comment definitely threw me into a
loop a few times.
So, let's rename this to make it's purpose more obvious regardless of where
in the code you are.
Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: Wayne Lin <Wayne.Lin@amd.com>
Cc: Fangzhi Zuo <Jerry.Zuo@amd.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
index 3aa385860eea..77c545e670d5 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
@@ -153,8 +153,9 @@ enum dc_edid_status dm_helpers_parse_edid_caps(
return result;
}
-static void get_payload_table(struct amdgpu_dm_connector *aconnector,
- struct dc_dp_mst_stream_allocation_table *proposed_table)
+static void
+fill_dc_mst_payload_table_from_drm(struct amdgpu_dm_connector *aconnector,
+ struct dc_dp_mst_stream_allocation_table *proposed_table)
{
int i;
struct drm_dp_mst_topology_mgr *mst_mgr =
@@ -252,7 +253,7 @@ bool dm_helpers_dp_mst_write_payload_allocation_table(
* stream. AMD ASIC stream slot allocation should follow the same
* sequence. copy DRM MST allocation to dc */
- get_payload_table(aconnector, proposed_table);
+ fill_dc_mst_payload_table_from_drm(aconnector, proposed_table);
return true;
}
--
2.37.1
next prev parent reply other threads:[~2022-08-17 19:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 19:38 [Intel-gfx] [RFC v4 00/17] drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only Lyude Paul
2022-08-17 19:38 ` [Intel-gfx] [RFC v4 01/17] drm/amdgpu/dc/mst: Rename dp_mst_stream_allocation(_table) Lyude Paul
2022-08-17 19:38 ` Lyude Paul [this message]
2022-08-17 19:38 ` [Intel-gfx] [RFC v4 03/17] drm/display/dp_mst: Rename drm_dp_mst_vcpi_allocation Lyude Paul
2022-08-17 19:38 ` [Intel-gfx] [RFC v4 04/17] drm/display/dp_mst: Call them time slots, not VCPI slots Lyude Paul
2022-08-17 19:38 ` [Intel-gfx] [RFC v4 05/17] drm/display/dp_mst: Fix confusing docs for drm_dp_atomic_release_time_slots() Lyude Paul
2022-08-17 19:38 ` [Intel-gfx] [RFC v4 06/17] drm/display/dp_mst: Add some missing kdocs for atomic MST structs Lyude Paul
2022-08-17 19:38 ` [Intel-gfx] [RFC v4 07/17] drm/display/dp_mst: Add helper for finding payloads in atomic MST state Lyude Paul
2022-08-17 19:38 ` [Intel-gfx] [RFC v4 08/17] drm/display/dp_mst: Add nonblocking helpers for DP MST Lyude Paul
2022-08-17 19:38 ` [Intel-gfx] [RFC v4 09/17] drm/display/dp_mst: Don't open code modeset checks for releasing time slots Lyude Paul
2022-08-17 19:38 ` [Intel-gfx] [RFC v4 10/17] drm/display/dp_mst: Fix modeset tracking in drm_dp_atomic_release_vcpi_slots() Lyude Paul
2022-08-17 19:38 ` [Intel-gfx] [RFC v4 11/17] drm/nouveau/kms: Cache DP encoders in nouveau_connector Lyude Paul
2022-08-17 19:38 ` [Intel-gfx] [RFC v4 12/17] drm/nouveau/kms: Pull mst state in for all modesets Lyude Paul
2022-08-17 19:38 ` [Intel-gfx] [RFC v4 13/17] drm/display/dp_mst: Add helpers for serializing SST <-> MST transitions Lyude Paul
2022-08-17 19:38 ` [Intel-gfx] [RFC v4 14/17] drm/display/dp_mst: Drop all ports from topology on CSNs before queueing link address work Lyude Paul
2022-08-17 19:38 ` [Intel-gfx] [RFC v4 15/17] drm/display/dp_mst: Maintain time slot allocations when deleting payloads Lyude Paul
2022-08-17 19:38 ` [Intel-gfx] [RFC v4 16/17] drm/radeon: Drop legacy MST support Lyude Paul
2022-08-17 19:38 ` [Intel-gfx] [RFC v4 17/17] drm/display/dp_mst: Move all payload info into the atomic state Lyude Paul
2022-08-17 19:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only (rev4) Patchwork
2022-08-17 20:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-08-18 3:34 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-08-23 17:26 ` [Intel-gfx] [RFC v4 00/17] drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only Lyude Paul
2022-08-23 21:09 ` Lyude Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220817193847.557945-3-lyude@redhat.com \
--to=lyude@redhat.com \
--cc=Bhawanpreet.Lakha@amd.com \
--cc=Jerry.Zuo@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Roman.Li@amd.com \
--cc=Wayne.Lin@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=colin.king@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=ian.chen@amd.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox