Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v2 3/4] drm/i915/display: Use drm helper instead of own loop for damage clips
Date: Tue, 23 Aug 2022 14:29:19 +0300	[thread overview]
Message-ID: <20220823112920.352563-4-jouni.hogander@intel.com> (raw)
In-Reply-To: <20220823112920.352563-1-jouni.hogander@intel.com>

Use existing drm_atomic_helper_damage_merged from generic drm code
instead of implementing own loop to iterate over damage_clips.

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
 drivers/gpu/drm/i915/display/intel_psr.c | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 16985de24019..0ce8076be000 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1721,8 +1721,6 @@ int intel_psr2_sel_fetch_update(struct intel_atomic_state *state,
 					     new_plane_state, i) {
 		struct drm_rect src, damaged_area = { .x1 = 0, .y1 = -1,
 						      .x2 = INT_MAX };
-		struct drm_atomic_helper_damage_iter iter;
-		struct drm_rect clip;
 
 		if (new_plane_state->uapi.crtc != crtc_state->uapi.crtc)
 			continue;
@@ -1770,20 +1768,15 @@ int intel_psr2_sel_fetch_update(struct intel_atomic_state *state,
 		src = drm_plane_state_src(&new_plane_state->uapi);
 		drm_rect_fp_to_int(&src, &src);
 
-		drm_atomic_helper_damage_iter_init(&iter,
-						   &old_plane_state->uapi,
-						   &new_plane_state->uapi);
-		drm_atomic_for_each_plane_damage(&iter, &clip) {
-			if (drm_rect_intersect(&clip, &src))
-				clip_area_update(&damaged_area, &clip,
-						 &crtc_state->pipe_src);
-		}
-
-		if (damaged_area.y1 == -1)
+		if (!drm_atomic_helper_damage_merged(&old_plane_state->uapi,
+						     &new_plane_state->uapi, &damaged_area))
 			continue;
 
 		damaged_area.y1 += new_plane_state->uapi.dst.y1 - src.y1;
 		damaged_area.y2 += new_plane_state->uapi.dst.y1 - src.y1;
+		damaged_area.x1 += new_plane_state->uapi.dst.x1 - src.x1;
+		damaged_area.x2 += new_plane_state->uapi.dst.x1 - src.x1;
+
 		clip_area_update(&pipe_clip, &damaged_area, &crtc_state->pipe_src);
 	}
 
-- 
2.34.1


  parent reply	other threads:[~2022-08-23 11:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-23 11:29 [Intel-gfx] [PATCH v2 0/4] Fixes for damage clips handling Jouni Högander
2022-08-23 11:29 ` [Intel-gfx] [PATCH v2 1/4] drm: Use original src rect while initializing damage iterator Jouni Högander
2022-09-02 10:58   ` Kahola, Mika
2022-08-23 11:29 ` [Intel-gfx] [PATCH v2 2/4] drm/i915/display: Use original src in psr2 sel fetch area calculation Jouni Högander
2022-09-02 10:59   ` Kahola, Mika
2022-08-23 11:29 ` Jouni Högander [this message]
2022-09-02 11:03   ` [Intel-gfx] [PATCH v2 3/4] drm/i915/display: Use drm helper instead of own loop for damage clips Kahola, Mika
2022-08-23 11:29 ` [Intel-gfx] [PATCH v2 4/4] drm/tests: Set also mock plane src_x, src_y, src_w and src_h Jouni Högander
2022-09-02 11:06   ` Kahola, Mika
2022-09-03 14:04   ` Maíra Canal
2022-08-23 12:44 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Fixes for damage clips handling (rev2) Patchwork
2022-08-23 13:03 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-08-24  7:05 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-09-02 16:28 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Fixes for damage clips handling (rev3) Patchwork
2022-09-02 16:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-09-02 23:08 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-09-06 18:11 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
2022-09-13  9:04 ` [Intel-gfx] [PATCH v2 0/4] Fixes for damage clips handling Ville Syrjälä
2022-09-13 10:47   ` Hogander, Jouni
2022-09-13 10:54     ` Thomas Zimmermann
2022-09-13 10:56       ` Thomas Zimmermann
2022-09-13 12:16         ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220823112920.352563-4-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox