From: Nirmoy Das <nirmoy.das@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: matthew.auld@intel.com
Subject: [Intel-gfx] [PATCH 2/2] drm/i915: remove excessive i915_gem_drain_freed_objects
Date: Thu, 8 Sep 2022 22:07:06 +0200 [thread overview]
Message-ID: <20220908200706.25773-2-nirmoy.das@intel.com> (raw)
In-Reply-To: <20220908200706.25773-1-nirmoy.das@intel.com>
i915_gem_drain_workqueue() call i915_gem_drain_freed_objects()
so no need to call that again.
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
drivers/gpu/drm/i915/i915_gem.c | 2 --
drivers/gpu/drm/i915/selftests/mock_gem_device.c | 1 -
2 files changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index e8a053eaaa89..e16718d79533 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -1217,8 +1217,6 @@ void i915_gem_driver_remove(struct drm_i915_private *dev_priv)
/* Flush any outstanding unpin_work. */
i915_gem_drain_workqueue(dev_priv);
-
- i915_gem_drain_freed_objects(dev_priv);
}
void i915_gem_driver_release(struct drm_i915_private *dev_priv)
diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
index f5904e659ef2..5d02346c43a2 100644
--- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
+++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
@@ -67,7 +67,6 @@ static void mock_device_release(struct drm_device *dev)
intel_gt_driver_remove(to_gt(i915));
i915_gem_drain_workqueue(i915);
- i915_gem_drain_freed_objects(i915);
mock_fini_ggtt(to_gt(i915)->ggtt);
destroy_workqueue(i915->wq);
--
2.37.3
next prev parent reply other threads:[~2022-09-08 20:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 20:07 [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload Nirmoy Das
2022-09-08 20:07 ` Nirmoy Das [this message]
2022-09-09 8:55 ` [Intel-gfx] [PATCH 2/2] drm/i915: remove excessive i915_gem_drain_freed_objects Tvrtko Ursulin
2022-09-08 20:47 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Fix a potential UAF at device unload Patchwork
2022-09-09 8:55 ` [Intel-gfx] [PATCH 1/2] " Tvrtko Ursulin
2022-09-21 15:53 ` Das, Nirmoy
2022-09-22 9:37 ` Tvrtko Ursulin
2022-09-22 12:11 ` Das, Nirmoy
2022-09-22 12:28 ` Tvrtko Ursulin
2022-09-22 12:32 ` Das, Nirmoy
-- strict thread matches above, loose matches on Subject: below --
2022-09-23 7:35 Nirmoy Das
2022-09-23 7:35 ` [Intel-gfx] [PATCH 2/2] drm/i915: remove excessive i915_gem_drain_freed_objects Nirmoy Das
2022-09-27 7:43 ` Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220908200706.25773-2-nirmoy.das@intel.com \
--to=nirmoy.das@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox