Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andrzej Hajda <andrzej.hajda@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: chris@chris-wilson.co.uk, Andrzej Hajda <andrzej.hajda@intel.com>,
	Matthew Auld <matthew.auld@intel.com>
Subject: [Intel-gfx] [PATCH] drm/i915/guc: do not capture error state on exiting context
Date: Mon, 26 Sep 2022 23:54:09 +0200	[thread overview]
Message-ID: <20220926215410.2268295-1-andrzej.hajda@intel.com> (raw)

Capturing error state is time consuming (up to 350ms on DG2), so it should
be avoided if possible. Context reset triggered by context removal is a
good example.
With this patch multiple igt tests will not timeout and should run faster.

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1551
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3952
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5891
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6268
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6281
Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
 drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
index 22ba66e48a9b01..cb58029208afe1 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
@@ -4425,7 +4425,8 @@ static void guc_handle_context_reset(struct intel_guc *guc,
 	trace_intel_context_reset(ce);
 
 	if (likely(!intel_context_is_banned(ce))) {
-		capture_error_state(guc, ce);
+		if (!intel_context_is_exiting(ce))
+			capture_error_state(guc, ce);
 		guc_context_replay(ce);
 	} else {
 		drm_info(&guc_to_gt(guc)->i915->drm,
-- 
2.34.1


             reply	other threads:[~2022-09-26 21:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-26 21:54 Andrzej Hajda [this message]
2022-09-26 22:44 ` [Intel-gfx] [PATCH] drm/i915/guc: do not capture error state on exiting context Andi Shyti
2022-09-26 23:34   ` Ceraolo Spurio, Daniele
2022-09-27  6:49     ` Andrzej Hajda
2022-09-27  7:45       ` Tvrtko Ursulin
2022-09-27  8:16         ` Andrzej Hajda
2022-09-27 21:36         ` Ceraolo Spurio, Daniele
2022-09-28  7:19           ` Tvrtko Ursulin
2022-09-28 18:27             ` John Harrison
2022-09-29  8:22               ` Tvrtko Ursulin
2022-09-29  9:49                 ` Andrzej Hajda
2022-09-29 10:40                   ` Tvrtko Ursulin
2022-09-29 14:28                     ` Ceraolo Spurio, Daniele
2022-09-29 16:49                 ` John Harrison
2022-09-27 10:14     ` Andrzej Hajda
2022-09-27 21:33       ` Ceraolo Spurio, Daniele
2022-09-27  2:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-09-27 13:50 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220926215410.2268295-1-andrzej.hajda@intel.com \
    --to=andrzej.hajda@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox