Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 2/2] drm/i915: Enable atomic by default on ctg/elk
Date: Sat,  8 Oct 2022 00:11:08 +0300	[thread overview]
Message-ID: <20221007211108.3883-2-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20221007211108.3883-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

The watermark code for ctg/elk has been atomic ready for a long time
so let's just flip the switch now that some of the last CxSR issues
have been sorted out (which granted was a problem for vlv/chv as well
despite them already having atomic enabled by default).

v2: Rebase

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_device_info.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
index b691b7c8c254..090097bb3c0a 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -508,8 +508,9 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
 		runtime->has_dsc = false;
 	}
 
-	/* Disable nuclear pageflip by default on pre-ILK */
-	if (!dev_priv->params.nuclear_pageflip && DISPLAY_VER(dev_priv) < 5)
+	/* Disable nuclear pageflip by default on pre-g4x */
+	if (!dev_priv->params.nuclear_pageflip &&
+	    DISPLAY_VER(dev_priv) < 5 && !IS_G4X(dev_priv))
 		dev_priv->drm.driver_features &= ~DRIVER_ATOMIC;
 }
 
-- 
2.35.1


  reply	other threads:[~2022-10-07 21:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-07 21:11 [Intel-gfx] [PATCH 1/2] drm/i915: Do the DRIVER_ATOMIC feature disable later Ville Syrjala
2022-10-07 21:11 ` Ville Syrjala [this message]
2022-10-10 11:51   ` [Intel-gfx] [PATCH 2/2] drm/i915: Enable atomic by default on ctg/elk Jani Nikula
2022-10-07 23:03 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Do the DRIVER_ATOMIC feature disable later Patchwork
2022-10-07 23:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-10-08  4:47 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-10-10 11:50 ` [Intel-gfx] [PATCH 1/2] " Jani Nikula
2022-10-11  6:58 ` Murthy, Arun R

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221007211108.3883-2-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox