From: Vinod Govindapillai <vinod.govindapillai@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [Intel-gfx] [PATCH v2 2/2] drm/i915/display: debugfs entry to control ignore long hpd flag
Date: Mon, 10 Oct 2022 11:34:47 +0300 [thread overview]
Message-ID: <20221010083447.139768-3-vinod.govindapillai@intel.com> (raw)
In-Reply-To: <20221010083447.139768-1-vinod.govindapillai@intel.com>
Knob to control ignoring the long hpds. Set this to true will
start ignoring the long HPDs generated by the displays. Useful
for use cases like CI systems where we dont expect to disconnect
the panels.
v2: Address patch styling comments (Jani Nikula)
Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
drivers/gpu/drm/i915/display/intel_hotplug.c | 25 ++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_hotplug.c b/drivers/gpu/drm/i915/display/intel_hotplug.c
index 352a1b53b63e..45c67f0f1c9f 100644
--- a/drivers/gpu/drm/i915/display/intel_hotplug.c
+++ b/drivers/gpu/drm/i915/display/intel_hotplug.c
@@ -936,6 +936,29 @@ static const struct file_operations i915_hpd_short_storm_ctl_fops = {
.write = i915_hpd_short_storm_ctl_write,
};
+static int i915_ignore_long_hpd_set(void *data, u64 val)
+{
+ struct drm_i915_private *i915 = data;
+
+ drm_dbg_kms(&i915->drm, "Ignoring long HPDs: %s\n", str_yes_no(val));
+
+ i915->display.hotplug.ignore_long_hpd = val;
+
+ return 0;
+}
+
+static int i915_ignore_long_hpd_get(void *data, u64 *val)
+{
+ struct drm_i915_private *i915 = data;
+
+ *val = i915->display.hotplug.ignore_long_hpd;
+
+ return 0;
+}
+
+DEFINE_SIMPLE_ATTRIBUTE(i915_ignore_long_hpd_fops, i915_ignore_long_hpd_get,
+ i915_ignore_long_hpd_set, "%llu\n");
+
void intel_hpd_debugfs_register(struct drm_i915_private *i915)
{
struct drm_minor *minor = i915->drm.primary;
@@ -944,4 +967,6 @@ void intel_hpd_debugfs_register(struct drm_i915_private *i915)
i915, &i915_hpd_storm_ctl_fops);
debugfs_create_file("i915_hpd_short_storm_ctl", 0644, minor->debugfs_root,
i915, &i915_hpd_short_storm_ctl_fops);
+ debugfs_create_file("i915_ignore_long_hpd", 0644, minor->debugfs_root,
+ i915, &i915_ignore_long_hpd_fops);
}
--
2.34.1
next prev parent reply other threads:[~2022-10-10 8:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 8:34 [Intel-gfx] [PATCH v2 0/2] Provision to ignore long HPDs in CI systems Vinod Govindapillai
2022-10-10 8:34 ` [Intel-gfx] [PATCH v2 1/2] drm/i915/display: ignore long HPDs based on a flag Vinod Govindapillai
2022-10-10 12:08 ` Andrzej Hajda
2022-10-10 12:11 ` Govindapillai, Vinod
2022-10-10 8:34 ` Vinod Govindapillai [this message]
2022-10-10 12:10 ` [Intel-gfx] [PATCH v2 2/2] drm/i915/display: debugfs entry to control ignore long hpd flag Andrzej Hajda
2022-10-10 8:52 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Provision to ignore long HPDs in CI systems (rev2) Patchwork
2022-10-10 9:01 ` Govindapillai, Vinod
2022-10-10 9:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-10-10 12:13 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2022-10-11 9:25 [Intel-gfx] [PATCH v2 0/2] Provision to ignore long HPDs in CI systems Vinod Govindapillai
2022-10-11 9:25 ` [Intel-gfx] [PATCH v2 2/2] drm/i915/display: debugfs entry to control ignore long hpd flag Vinod Govindapillai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221010083447.139768-3-vinod.govindapillai@intel.com \
--to=vinod.govindapillai@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox