From: Vinod Govindapillai <vinod.govindapillai@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com, ville.syrjala@intel.com, lucas.demarchi@intel.com
Subject: [Intel-gfx] [PATCH v2 1/2] drm/i915/display: ignore long HPDs based on a flag
Date: Tue, 11 Oct 2022 12:25:07 +0300 [thread overview]
Message-ID: <20221011092508.445966-2-vinod.govindapillai@intel.com> (raw)
In-Reply-To: <20221011092508.445966-1-vinod.govindapillai@intel.com>
Some panels generate long HPD events even while connected to
the port. This cause some unexpected CI execution issues. A
new flag is added to track if such spurious long HPDs can be
ignored and are not processed further if the flag is set.
v2: Address patch styling comments (Jani Nikula)
Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
drivers/gpu/drm/i915/display/intel_display_core.h | 11 +++++++++++
drivers/gpu/drm/i915/display/intel_dp.c | 7 +++++++
2 files changed, 18 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_display_core.h b/drivers/gpu/drm/i915/display/intel_display_core.h
index 96cf994b0ad1..f84a2e760ef4 100644
--- a/drivers/gpu/drm/i915/display/intel_display_core.h
+++ b/drivers/gpu/drm/i915/display/intel_display_core.h
@@ -170,6 +170,17 @@ struct intel_hotplug {
* blocked behind the non-DP one.
*/
struct workqueue_struct *dp_wq;
+
+ /*
+ * Flag to track if long HPDs need not to be processed
+ *
+ * Some panels generate long HPDs while keep connected to the port.
+ * This can cause issues with CI tests results. In CI systems we
+ * don't expect to disconnect the panels and could ignore the long
+ * HPDs generated from the faulty panels. This flag can be used as
+ * cue to ignore the long HPDs and can be set / unset using debugfs.
+ */
+ bool ignore_long_hpd;
};
struct intel_vbt_data {
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 70b06806ec0d..87a0d01d8003 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -5092,6 +5092,13 @@ intel_dp_hpd_pulse(struct intel_digital_port *dig_port, bool long_hpd)
return IRQ_HANDLED;
}
+ if (i915->display.hotplug.ignore_long_hpd && long_hpd) {
+ drm_dbg_kms(&i915->drm, "[ENCODER:%d:%s] ignoring long hpd\n",
+ dig_port->base.base.base.id,
+ dig_port->base.base.name);
+ return IRQ_HANDLED;
+ }
+
drm_dbg_kms(&i915->drm, "got hpd irq on [ENCODER:%d:%s] - %s\n",
dig_port->base.base.base.id,
dig_port->base.base.name,
--
2.34.1
next prev parent reply other threads:[~2022-10-11 9:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 9:25 [Intel-gfx] [PATCH v2 0/2] Provision to ignore long HPDs in CI systems Vinod Govindapillai
2022-10-11 9:25 ` Vinod Govindapillai [this message]
2022-10-11 9:25 ` [Intel-gfx] [PATCH v2 2/2] drm/i915/display: debugfs entry to control ignore long hpd flag Vinod Govindapillai
2022-10-11 9:29 ` [Intel-gfx] [PATCH v2 0/2] Provision to ignore long HPDs in CI systems Govindapillai, Vinod
2022-10-11 10:06 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Provision to ignore long HPDs in CI systems (rev3) Patchwork
2022-10-11 10:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-10-11 12:05 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2022-10-10 8:34 [Intel-gfx] [PATCH v2 0/2] Provision to ignore long HPDs in CI systems Vinod Govindapillai
2022-10-10 8:34 ` [Intel-gfx] [PATCH v2 1/2] drm/i915/display: ignore long HPDs based on a flag Vinod Govindapillai
2022-10-10 12:08 ` Andrzej Hajda
2022-10-10 12:11 ` Govindapillai, Vinod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221011092508.445966-2-vinod.govindapillai@intel.com \
--to=vinod.govindapillai@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=lucas.demarchi@intel.com \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox