From: "Steven 'Steve' Kendall" <skend@chromium.org>
To: intel-gfx@lists.freedesktop.org
Cc: daniel@ffwll.ch, rodrigo.vivi@intel.com,
Steven 'Steve' Kendall <skend@google.com>,
airlied@gmail.com
Subject: [Intel-gfx] [PATCH] drm/i915: disable DMC idle states for Intel UHD Graphics 620
Date: Fri, 11 Nov 2022 22:49:30 +0000 [thread overview]
Message-ID: <20221111224930.3961511-1-skend@google.com> (raw)
Some machines with Intel UHD Graphics 620 (8086:5917) such as Dell
Latitude 7490 are unable to wake from sleep. Disable DMC for
Intel UHD Graphics 620.
Link: https://gitlab.freedesktop.org/drm/intel/-/issues/7339
Signed-off-by: Steven 'Steve' Kendall <skend@google.com>
---
drivers/gpu/drm/i915/i915_pci.c | 14 ++++++++++++++
include/drm/i915_pciids.h | 6 +++++-
2 files changed, 19 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index cd4487a1d3be..ea148be46b14 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -697,6 +697,10 @@ static const struct intel_device_info skl_gt4_info = {
.gt = 4,
};
+#define GEN9_DMCLESS_FEATURES \
+ GEN9_FEATURES, \
+ .__runtime.has_dmc = 0
+
#define GEN9_LP_FEATURES \
GEN(9), \
.is_lp = 1, \
@@ -753,6 +757,10 @@ static const struct intel_device_info glk_info = {
GEN9_FEATURES, \
PLATFORM(INTEL_KABYLAKE)
+#define KBL_DMCLESS_PLATFORM \
+ GEN9_DMCLESS_FEATURES, \
+ PLATFORM(INTEL_KABYLAKE)
+
static const struct intel_device_info kbl_gt1_info = {
KBL_PLATFORM,
.gt = 1,
@@ -763,6 +771,11 @@ static const struct intel_device_info kbl_gt2_info = {
.gt = 2,
};
+static const struct intel_device_info dmcless_kbl_gt2_info = {
+ KBL_DMCLESS_PLATFORM,
+ .gt = 2,
+};
+
static const struct intel_device_info kbl_gt3_info = {
KBL_PLATFORM,
.gt = 3,
@@ -1202,6 +1215,7 @@ static const struct pci_device_id pciidlist[] = {
INTEL_GLK_IDS(&glk_info),
INTEL_KBL_GT1_IDS(&kbl_gt1_info),
INTEL_KBL_GT2_IDS(&kbl_gt2_info),
+ DMCLESS_INTEL_KBL_GT2_IDS(&dmcless_kbl_gt2_info),
INTEL_KBL_GT3_IDS(&kbl_gt3_info),
INTEL_KBL_GT4_IDS(&kbl_gt3_info),
INTEL_AML_KBL_GT2_IDS(&kbl_gt2_info),
diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
index 4a4c190f7698..93bea60772ff 100644
--- a/include/drm/i915_pciids.h
+++ b/include/drm/i915_pciids.h
@@ -420,11 +420,15 @@
INTEL_KBL_ULT_GT2_IDS(info), \
INTEL_KBL_ULX_GT2_IDS(info), \
INTEL_VGA_DEVICE(0x5912, info), /* DT GT2 */ \
- INTEL_VGA_DEVICE(0x5917, info), /* Mobile GT2 */ \
INTEL_VGA_DEVICE(0x591A, info), /* SRV GT2 */ \
INTEL_VGA_DEVICE(0x591B, info), /* Halo GT2 */ \
INTEL_VGA_DEVICE(0x591D, info) /* WKS GT2 */
+#define DMCLESS_INTEL_KBL_GT2_IDS(info) \
+ INTEL_KBL_ULT_GT2_IDS(info), \
+ INTEL_KBL_ULX_GT2_IDS(info), \
+ INTEL_VGA_DEVICE(0x5917, info) /* Mobile GT2 */
+
#define INTEL_KBL_ULT_GT3_IDS(info) \
INTEL_VGA_DEVICE(0x5926, info) /* ULT GT3 */
--
2.38.1.431.g37b22c650d-goog
next reply other threads:[~2022-11-11 22:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 22:49 Steven 'Steve' Kendall [this message]
2022-11-11 23:49 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: disable DMC idle states for Intel UHD Graphics 620 Patchwork
2022-11-14 11:11 ` [Intel-gfx] [PATCH] " Jani Nikula
2022-11-14 19:25 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221111224930.3961511-1-skend@google.com \
--to=skend@chromium.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=skend@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox