Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 2/9] drm/i915/dvo: Don't leak connector state on DVO init failure
Date: Fri, 18 Nov 2022 12:55:18 +0200	[thread overview]
Message-ID: <20221118105525.27254-3-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20221118105525.27254-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

If we can't initialize the DVO encoder also free the connector
state allocated by intel_connector_alloc().

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dvo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dvo.c b/drivers/gpu/drm/i915/display/intel_dvo.c
index 94dcc43876c9..8859e400b860 100644
--- a/drivers/gpu/drm/i915/display/intel_dvo.c
+++ b/drivers/gpu/drm/i915/display/intel_dvo.c
@@ -535,5 +535,5 @@ void intel_dvo_init(struct drm_i915_private *dev_priv)
 	}
 
 	kfree(intel_dvo);
-	kfree(intel_connector);
+	intel_connector_free(intel_connector);
 }
-- 
2.37.4


  parent reply	other threads:[~2022-11-18 10:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-18 10:55 [Intel-gfx] [PATCH 0/9] drm/i915/dvo: DVO init fixes/cleanps Ville Syrjala
2022-11-18 10:55 ` [Intel-gfx] [PATCH 1/9] drm/i915/dvo: Remove unused panel_wants_dither Ville Syrjala
2022-11-18 10:55 ` Ville Syrjala [this message]
2022-11-18 10:55 ` [Intel-gfx] [PATCH 3/9] drm/i915/dvo: Actually initialize the DVO encoder type Ville Syrjala
2022-11-18 10:55 ` [Intel-gfx] [PATCH 4/9] drm/i915/dvo: Introduce intel_dvo_connector_type() Ville Syrjala
2022-11-18 10:55 ` [Intel-gfx] [PATCH 5/9] drm/i915/dvo: Eliminate useless 'port' variable Ville Syrjala
2022-11-18 10:55 ` [Intel-gfx] [PATCH 6/9] drm/i915/dvo: Flatten intel_dvo_init() Ville Syrjala
2022-11-18 10:55 ` [Intel-gfx] [PATCH 7/9] drm/i915/dvo: s/intel_encoder/encoder/ etc Ville Syrjala
2022-11-18 10:55 ` [Intel-gfx] [PATCH 8/9] drm/i915/dvo: s/dev_priv/i915/ Ville Syrjala
2022-11-18 10:55 ` [Intel-gfx] [PATCH 9/9] drm/i915/dvo: Use per device debugs Ville Syrjala
2022-11-18 11:39 ` [Intel-gfx] [PATCH 0/9] drm/i915/dvo: DVO init fixes/cleanps Jani Nikula
2022-11-18 11:44 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-11-18 12:06 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-11-19  2:38 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221118105525.27254-3-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox