From: Kees Cook <keescook@chromium.org>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/hti: avoid theoretically possible negative shift
Date: Tue, 22 Nov 2022 21:16:34 -0800 [thread overview]
Message-ID: <202211222116.5B28E9B8B@keescook> (raw)
In-Reply-To: <20221122120948.3436180-1-jani.nikula@intel.com>
On Tue, Nov 22, 2022 at 02:09:48PM +0200, Jani Nikula wrote:
> If phy is PHY_NONE, the shift to register bits becomes negative. Check
> and warn about this.
>
> Reported-by: coverity-bot <keescook@chromium.org>
> References: https://lore.kernel.org/r/202211180848.D39006C@keescook
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2022-11-23 5:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 12:09 [Intel-gfx] [PATCH] drm/i915/hti: avoid theoretically possible negative shift Jani Nikula
2022-11-22 17:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-11-23 4:25 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-11-23 5:16 ` Kees Cook [this message]
2022-11-23 9:18 ` [Intel-gfx] [PATCH] " Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202211222116.5B28E9B8B@keescook \
--to=keescook@chromium.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox