From: Nischal Varide <nischal.varide@intel.com>
To: intel-gfx@lists.freedesktop.org, nischal.varide@intel.com
Subject: [Intel-gfx] [PATCH] drm/i915/display: A check on mode->clock, if it exceeds max_dot_clock
Date: Wed, 23 Nov 2022 13:13:56 +0530 [thread overview]
Message-ID: <20221123074356.7513-1-nischal.varide@intel.com> (raw)
Making sure that the mode-clock is not greater than the
max_dot_clock freq.This patch will prevent attempts from
userspace to modeset with mode->clock greater than
max_dot_clock freq.
Signed-off-by: Nischal Varide <nischal.varide@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 10 ++++++++++
drivers/gpu/drm/i915/display/intel_hdmi.c | 3 +++
2 files changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 7400d6b4c587..e603b7c01d27 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -2045,6 +2045,16 @@ intel_dp_compute_config(struct intel_encoder *encoder,
if (intel_dp_hdisplay_bad(dev_priv, adjusted_mode->crtc_hdisplay))
return -EINVAL;
+ if (!intel_dp_can_bigjoiner(intel_dp) &&
+ (adjusted_mode->clock > dev_priv->max_dotclk_freq))
+ return -EINVAL;
+
+ if (intel_dp_can_bigjoiner(intel_dp) &&
+ (adjusted_mode->clock > (2 * dev_priv->max_dotclk_freq)))
+ return -EINVAL;
+
+
+
/*
* Try to respect downstream TMDS clock limits first, if
* that fails assume the user might know something we don't.
diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
index 02f8374ea51f..50603806a964 100644
--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
@@ -2247,6 +2247,9 @@ int intel_hdmi_compute_config(struct intel_encoder *encoder,
if (adjusted_mode->flags & DRM_MODE_FLAG_DBLSCAN)
return -EINVAL;
+ if (adjusted_mode->clock > dev_priv->max_dotclk_freq)
+ return -EINVAL;
+
pipe_config->output_format = INTEL_OUTPUT_FORMAT_RGB;
pipe_config->has_hdmi_sink = intel_has_hdmi_sink(intel_hdmi,
conn_state);
--
2.36.0
next reply other threads:[~2022-11-23 7:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 7:43 Nischal Varide [this message]
2022-11-23 7:55 ` [Intel-gfx] [PATCH] drm/i915/display: A check on mode->clock, if it exceeds max_dot_clock Ville Syrjälä
2022-11-23 8:07 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-11-23 9:29 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-11-23 11:21 ` [Intel-gfx] [PATCH] " Jani Nikula
2022-11-23 22:34 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221123074356.7513-1-nischal.varide@intel.com \
--to=nischal.varide@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox