From: Simon Ser <contact@emersion.fr>
To: intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>
Subject: [Intel-gfx] [PATCH 1/2] drm/i915/dp_mst: log when pulling CRTCs into atomic state
Date: Thu, 15 Dec 2022 15:51:45 +0000 [thread overview]
Message-ID: <20221215155138.246676-1-contact@emersion.fr> (raw)
It can be surprising for user-space to see unrelated connectors,
CRTCs and planes being implicitly pulled into the atomic commit.
Log when that happens.
Signed-off-by: Simon Ser <contact@emersion.fr>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Lyude Paul <lyude@redhat.com>
---
drivers/gpu/drm/i915/display/intel_dp_mst.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
index 4077a979a924..f773e117ebc4 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
@@ -293,6 +293,10 @@ intel_dp_mst_atomic_master_trans_check(struct intel_connector *connector,
if (!conn_iter_state->base.crtc)
continue;
+ drm_dbg_kms(&dev_priv->drm,
+ "Adding [CONNECTOR:%d:%s] which shares the same DP-MST stream\n",
+ connector_iter->base.base.id, connector_iter->base.name);
+
crtc = to_intel_crtc(conn_iter_state->base.crtc);
crtc_state = intel_atomic_get_crtc_state(&state->base, crtc);
if (IS_ERR(crtc_state)) {
--
2.39.0
next reply other threads:[~2022-12-15 15:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 15:51 Simon Ser [this message]
2022-12-15 15:51 ` [Intel-gfx] [PATCH 2/2] drm/i915/dp_mst: don't pull unregistered connectors into state Simon Ser
2022-12-20 10:39 ` Ville Syrjälä
2022-12-20 11:09 ` Imre Deak
2022-12-15 16:30 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/dp_mst: log when pulling CRTCs into atomic state Patchwork
2022-12-16 14:09 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-12-21 22:02 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/dp_mst: log when pulling CRTCs into atomic state (rev2) Patchwork
2022-12-21 22:02 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-12-21 23:24 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-12-22 2:08 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221215155138.246676-1-contact@emersion.fr \
--to=contact@emersion.fr \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox