Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sasa Dragic <sasa.dragic@gmail.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 1/1] drm/i915: re-disable RC6p on Sandy Bridge
Date: Mon, 19 Dec 2022 18:29:27 +0100	[thread overview]
Message-ID: <20221219172927.9603-2-sasa.dragic@gmail.com> (raw)
In-Reply-To: <20221219172927.9603-1-sasa.dragic@gmail.com>

RC6p on Sandy Bridge got re-enabled over time, causing visual glitches
and GPU hangs.

Disabled originally in commit 1c8ecf80fdee ("drm/i915: do not enable
RC6p on Sandy Bridge").

Signed-off-by: Sasa Dragic <sasa.dragic@gmail.com>
---
 drivers/gpu/drm/i915/i915_pci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index 668e9da52584..69377564028a 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -423,7 +423,8 @@ static const struct intel_device_info ilk_m_info = {
 	.has_coherent_ggtt = true, \
 	.has_llc = 1, \
 	.has_rc6 = 1, \
-	.has_rc6p = 1, \
+	/* snb does support rc6p, but enabling it causes various issues */ \
+	.has_rc6p = 0, \
 	.has_rps = true, \
 	.dma_mask_size = 40, \
 	.__runtime.ppgtt_type = INTEL_PPGTT_ALIASING, \
-- 
2.37.2


  reply	other threads:[~2022-12-19 17:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-19 17:29 [Intel-gfx] [PATCH 0/1] fix RC6p related regression on Sandy Bridge Sasa Dragic
2022-12-19 17:29 ` Sasa Dragic [this message]
2022-12-20 10:32   ` [Intel-gfx] [PATCH 1/1] drm/i915: re-disable RC6p " Ville Syrjälä
2022-12-20 15:50     ` Sasa Dragic
2022-12-21 14:09     ` Rodrigo Vivi
2023-01-17 22:50       ` Ville Syrjälä
2022-12-21 17:40 ` [Intel-gfx] ✓ Fi.CI.BAT: success for fix RC6p related regression " Patchwork
2022-12-21 18:52 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221219172927.9603-2-sasa.dragic@gmail.com \
    --to=sasa.dragic@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox