From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 2/5] drm/i915/psr: Fix the delayed vblank w/a
Date: Thu, 22 Dec 2022 14:00:45 +0200 [thread overview]
Message-ID: <20221222120048.8740-3-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20221222120048.8740-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Fix the code to correctly determine whether delayed vblank
is used or not.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_psr.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 9820e5fdd087..70bd4e69834c 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1200,13 +1200,8 @@ static void intel_psr_enable_source(struct intel_dp *intel_dp,
/* Wa_16013835468:tgl[b0+], dg1 */
if (IS_TGL_DISPLAY_STEP(dev_priv, STEP_B0, STEP_FOREVER) ||
IS_DG1(dev_priv)) {
- u16 vtotal, vblank;
-
- vtotal = crtc_state->uapi.adjusted_mode.crtc_vtotal -
- crtc_state->uapi.adjusted_mode.crtc_vdisplay;
- vblank = crtc_state->uapi.adjusted_mode.crtc_vblank_end -
- crtc_state->uapi.adjusted_mode.crtc_vblank_start;
- if (vblank > vtotal)
+ if (crtc_state->hw.adjusted_mode.crtc_vblank_start !=
+ crtc_state->hw.adjusted_mode.crtc_vdisplay)
intel_de_rmw(dev_priv, GEN8_CHICKEN_DCPR_1, 0,
wa_16013835468_bit_get(intel_dp));
}
--
2.38.2
next prev parent reply other threads:[~2022-12-22 12:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 12:00 [Intel-gfx] [PATCH 0/5] drm/i915: vblank stuff Ville Syrjala
2022-12-22 12:00 ` [Intel-gfx] [PATCH 1/5] drm/i915/vrr: Fix "window2" handling Ville Syrjala
2022-12-22 12:00 ` Ville Syrjala [this message]
2023-01-30 7:15 ` [Intel-gfx] [PATCH 2/5] drm/i915/psr: Fix the delayed vblank w/a Hogander, Jouni
2022-12-22 12:00 ` [Intel-gfx] [PATCH 3/5] drm/i915/psr: Add the latency reporting chicken bit for pipe D Ville Syrjala
2023-01-30 7:18 ` Hogander, Jouni
2022-12-22 12:00 ` [Intel-gfx] [PATCH 4/5] drm/i915: Extract skl_wm_latency() Ville Syrjala
2022-12-22 12:00 ` [Intel-gfx] [PATCH 5/5] drm/i915: Reject wm levels that exceed vblank time Ville Syrjala
2022-12-22 20:02 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: vblank stuff Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221222120048.8740-3-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox