From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [Intel-gfx] [PATCH 1/4] drm/i915/gt: add sparse lock annotation to avoid warnings
Date: Tue, 7 Feb 2023 14:40:23 +0200 [thread overview]
Message-ID: <20230207124026.2105442-1-jani.nikula@intel.com> (raw)
Annotate intel_gt_mcr_lock() and intel_gt_mcr_unlock() to fix sparse
warnings:
drivers/gpu/drm/i915/gt/intel_gt_mcr.c:397:9: warning: context imbalance in 'intel_gt_mcr_lock' - wrong count at exit
drivers/gpu/drm/i915/gt/intel_gt_mcr.c:412:6: warning: context imbalance in 'intel_gt_mcr_unlock' - unexpected unlock
Cc: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/gt/intel_gt_mcr.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c
index 169393a7ad88..a4a8b8bc5737 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c
@@ -364,6 +364,7 @@ static u32 rw_with_mcr_steering(struct intel_gt *gt,
* function call.
*/
void intel_gt_mcr_lock(struct intel_gt *gt, unsigned long *flags)
+ __acquires(>->mcr_lock)
{
unsigned long __flags;
int err = 0;
@@ -410,6 +411,7 @@ void intel_gt_mcr_lock(struct intel_gt *gt, unsigned long *flags)
* Context: Releases gt->mcr_lock
*/
void intel_gt_mcr_unlock(struct intel_gt *gt, unsigned long flags)
+ __releases(>->mcr_lock)
{
spin_unlock_irqrestore(>->mcr_lock, flags);
--
2.34.1
next reply other threads:[~2023-02-07 12:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 12:40 Jani Nikula [this message]
2023-02-07 12:40 ` [Intel-gfx] [PATCH 2/4] drm/i915/uncore: cast iomem to avoid sparse warning Jani Nikula
2023-02-07 19:05 ` Matt Roper
2023-02-07 12:40 ` [Intel-gfx] [PATCH 3/4] drm/i915/syncmap: squelch a " Jani Nikula
2023-02-07 12:40 ` [Intel-gfx] [PATCH 4/4] drm/i915/pxp: fix __le64 access to get rid of " Jani Nikula
2023-02-07 12:44 ` Winkler, Tomas
2023-02-07 13:21 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915/gt: add sparse lock annotation to avoid warnings Patchwork
2023-02-07 13:53 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-02-07 15:20 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/gt: add sparse lock annotation to avoid warnings (rev2) Patchwork
2023-02-07 15:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-02-07 18:13 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-02-07 19:03 ` [Intel-gfx] [PATCH 1/4] drm/i915/gt: add sparse lock annotation to avoid warnings Matt Roper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230207124026.2105442-1-jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox