From: Ashutosh Dixit <ashutosh.dixit@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 2/2] drm/i915/pmu: Use correct requested freq for SLPC
Date: Fri, 3 Mar 2023 17:27:05 -0800 [thread overview]
Message-ID: <20230304012705.70003-3-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20230304012705.70003-1-ashutosh.dixit@intel.com>
SLPC does not use 'struct intel_rps'. Use UNSLICE_RATIO bits from
GEN6_RPNSWREQ for SLPC. See intel_rps_get_requested_frequency.
Bspec: 52745
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
drivers/gpu/drm/i915/i915_pmu.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c
index f0a1e36915b8..5ee836610801 100644
--- a/drivers/gpu/drm/i915/i915_pmu.c
+++ b/drivers/gpu/drm/i915/i915_pmu.c
@@ -394,8 +394,13 @@ frequency_sample(struct intel_gt *gt, unsigned int period_ns)
* frequency. Fortunately, the read should rarely fail!
*/
val = intel_rps_get_cagf(rps, intel_rps_read_rpstat_fw(rps));
- if (!val)
- val = rps->cur_freq;
+ if (!val) {
+ if (intel_uc_uses_guc_slpc(>->uc))
+ val = intel_rps_read_punit_req(rps) >>
+ GEN9_SW_REQ_UNSLICE_RATIO_SHIFT;
+ else
+ val = rps->cur_freq;
+ }
add_sample_mult(&pmu->sample[__I915_SAMPLE_FREQ_ACT],
intel_gpu_freq(rps, val), period_ns / 1000);
--
2.38.0
next prev parent reply other threads:[~2023-03-04 1:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-04 1:27 [Intel-gfx] [PATCH 0/2] drm/i915/pmu: Freq sampling: Fix requested freq fallback Ashutosh Dixit
2023-03-04 1:27 ` [Intel-gfx] [PATCH 1/2] drm/i915/pmu: Use only freq bits for falling back to requested freq Ashutosh Dixit
2023-03-06 11:04 ` Tvrtko Ursulin
2023-03-08 5:36 ` Dixit, Ashutosh
2023-03-08 10:40 ` Tvrtko Ursulin
2023-03-04 1:27 ` Ashutosh Dixit [this message]
2023-03-06 11:10 ` [Intel-gfx] [PATCH 2/2] drm/i915/pmu: Use correct requested freq for SLPC Tvrtko Ursulin
2023-03-08 5:36 ` Dixit, Ashutosh
2023-03-08 10:52 ` Tvrtko Ursulin
2023-03-04 2:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Freq sampling: Fix requested freq fallback Patchwork
2023-03-06 22:52 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230304012705.70003-3-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox