Re: [Intel-gfx] [PATCH 5/5] drm/debugfs: remove debugfs_root pointer from minor

[kernel test robot <lkp@intel.com>]

Hi Christian,

I love your patch! Yet something to improve:

[auto build test ERROR on drm-tip/drm-tip]

url:    https://github.com/intel-lab-lkp/linux/commits/Christian-K-nig/drm-debugfs-rework-debugfs-directory-creation-v2/20230328-223907
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
patch link:    https://lore.kernel.org/r/20230328143709.86644-5-christian.koenig%40amd.com
patch subject: [Intel-gfx] [PATCH 5/5] drm/debugfs: remove debugfs_root pointer from minor
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20230329/202303291026.iRc2NXSy-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/a17b8a95102c9f2cf2b5cadadcf99c364dafed15
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Christian-K-nig/drm-debugfs-rework-debugfs-directory-creation-v2/20230328-223907
        git checkout a17b8a95102c9f2cf2b5cadadcf99c364dafed15
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/drm/i915/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303291026.iRc2NXSy-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/gpu/drm/i915/display/intel_hotplug.c: In function 'intel_hpd_debugfs_register':
>> drivers/gpu/drm/i915/display/intel_hotplug.c:950:64: error: 'struct drm_minor' has no member named 'debugfs_root'
     950 |         debugfs_create_bool("i915_ignore_long_hpd", 0644, minor->debugfs_root,
         |                                                                ^~
--
   drivers/gpu/drm/i915/display/intel_psr.c: In function 'intel_psr_debugfs_register':
>> drivers/gpu/drm/i915/display/intel_psr.c:2873:62: error: 'struct drm_minor' has no member named 'debugfs_root'
    2873 |         debugfs_create_file("i915_edp_psr_debug", 0644, minor->debugfs_root,
         |                                                              ^~
   drivers/gpu/drm/i915/display/intel_psr.c:2876:63: error: 'struct drm_minor' has no member named 'debugfs_root'
    2876 |         debugfs_create_file("i915_edp_psr_status", 0444, minor->debugfs_root,
         |                                                               ^~
--
   drivers/gpu/drm/i915/display/intel_wm.c: In function 'intel_wm_debugfs_register':
>> drivers/gpu/drm/i915/display/intel_wm.c:398:63: error: 'struct drm_minor' has no member named 'debugfs_root'
     398 |         debugfs_create_file("i915_pri_wm_latency", 0644, minor->debugfs_root,
         |                                                               ^~
   drivers/gpu/drm/i915/display/intel_wm.c:401:63: error: 'struct drm_minor' has no member named 'debugfs_root'
     401 |         debugfs_create_file("i915_spr_wm_latency", 0644, minor->debugfs_root,
         |                                                               ^~
   drivers/gpu/drm/i915/display/intel_wm.c:404:63: error: 'struct drm_minor' has no member named 'debugfs_root'
     404 |         debugfs_create_file("i915_cur_wm_latency", 0644, minor->debugfs_root,
         |                                                               ^~


vim +950 drivers/gpu/drm/i915/display/intel_hotplug.c

1bed8b07342069e Jani Nikula         2022-09-16  941  
1bed8b07342069e Jani Nikula         2022-09-16  942  void intel_hpd_debugfs_register(struct drm_i915_private *i915)
1bed8b07342069e Jani Nikula         2022-09-16  943  {
1bed8b07342069e Jani Nikula         2022-09-16  944  	struct drm_minor *minor = i915->drm.primary;
1bed8b07342069e Jani Nikula         2022-09-16  945  
a17b8a95102c9f2 Christian König     2023-03-28  946  	debugfs_create_file("i915_hpd_storm_ctl", 0644, minor->dev->debugfs_root,
1bed8b07342069e Jani Nikula         2022-09-16  947  			    i915, &i915_hpd_storm_ctl_fops);
a17b8a95102c9f2 Christian König     2023-03-28  948  	debugfs_create_file("i915_hpd_short_storm_ctl", 0644, minor->dev->debugfs_root,
1bed8b07342069e Jani Nikula         2022-09-16  949  			    i915, &i915_hpd_short_storm_ctl_fops);
b0fbef65e227ad4 Vinod Govindapillai 2023-02-15 @950  	debugfs_create_bool("i915_ignore_long_hpd", 0644, minor->debugfs_root,

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests