Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: fei.yang@intel.com
To: intel-gfx@lists.freedesktop.org
Cc: Matt Roper <matthew.d.roper@intel.com>, dri-devel@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v4 2/8] drm/i915/mtl: fix mocs selftest
Date: Fri, 21 Apr 2023 10:37:55 -0700	[thread overview]
Message-ID: <20230421173801.3369303-3-fei.yang@intel.com> (raw)
In-Reply-To: <20230421173801.3369303-1-fei.yang@intel.com>

From: Fei Yang <fei.yang@intel.com>

Media GT has a different base for MOCS register, need to apply
gsi_offset to the mmio address if not using the intel_uncore_r/w
functions for register access.

Cc: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Fei Yang <fei.yang@intel.com>
---
 drivers/gpu/drm/i915/gt/selftest_mocs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/selftest_mocs.c b/drivers/gpu/drm/i915/gt/selftest_mocs.c
index ca009a6a13bd..a8446ab82501 100644
--- a/drivers/gpu/drm/i915/gt/selftest_mocs.c
+++ b/drivers/gpu/drm/i915/gt/selftest_mocs.c
@@ -131,13 +131,14 @@ static int read_mocs_table(struct i915_request *rq,
 			   const struct drm_i915_mocs_table *table,
 			   u32 *offset)
 {
+	struct intel_gt *gt = rq->engine->gt;
 	u32 addr;
 
 	if (!table)
 		return 0;
 
 	if (HAS_GLOBAL_MOCS_REGISTERS(rq->engine->i915))
-		addr = global_mocs_offset();
+		addr = global_mocs_offset() + gt->uncore->gsi_offset;
 	else
 		addr = mocs_offset(rq->engine);
 
-- 
2.25.1


  parent reply	other threads:[~2023-04-21 17:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-21 17:37 [Intel-gfx] [PATCH v4 0/8] drm/i915/mtl: Define MOCS and PAT tables for MTL fei.yang
2023-04-21 17:37 ` [Intel-gfx] [PATCH v4 1/8] " fei.yang
2023-04-21 17:37 ` fei.yang [this message]
2023-04-21 17:45   ` [Intel-gfx] [PATCH v4 2/8] drm/i915/mtl: fix mocs selftest Matt Roper
2023-04-21 17:37 ` [Intel-gfx] [PATCH v4 3/8] drm/i915/mtl: Add PTE encode function fei.yang
2023-04-21 17:37 ` [Intel-gfx] [PATCH v4 4/8] drm/i915: preparation for using PAT index fei.yang
2023-04-21 17:37 ` [Intel-gfx] [PATCH v4 5/8] drm/i915: use pat_index instead of cache_level fei.yang
2023-04-21 17:37 ` [Intel-gfx] [PATCH v4 6/8] drm/i915: make sure correct pte encode is used fei.yang
2023-04-21 17:38 ` [Intel-gfx] [PATCH v4 7/8] drm/i915/mtl: end support for set caching ioctl fei.yang
2023-04-21 17:38 ` [Intel-gfx] [PATCH v4 8/8] drm/i915: Allow user to set cache at BO creation fei.yang
2023-04-21 17:50   ` Matt Roper
2023-04-21 21:22 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/mtl: Define MOCS and PAT tables for MTL (rev10) Patchwork
2023-04-21 21:22 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-04-21 21:36 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-04-22  7:53 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230421173801.3369303-3-fei.yang@intel.com \
    --to=fei.yang@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox