From: Vinod Govindapillai <vinod.govindapillai@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: ville.syrjala@intel.com, gustavo.souza@intel.com
Subject: [Intel-gfx] [PATCH v1 1/7] drm/i915: update the QGV point frequency calculations
Date: Tue, 25 Apr 2023 23:20:50 +0300 [thread overview]
Message-ID: <20230425202056.1143994-2-vinod.govindapillai@intel.com> (raw)
In-Reply-To: <20230425202056.1143994-1-vinod.govindapillai@intel.com>
From MTL onwwards, pcode locks the QGV point based on peak BW of
the intended QGV point passed by the driver. So the peak BW
calculation must match the value expected by the pcode. Update
the calculations as per the Bspec.
Bspec: 64636
Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
drivers/gpu/drm/i915/display/intel_bw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
index ab405c48ca3a..25ae4e5834d3 100644
--- a/drivers/gpu/drm/i915/display/intel_bw.c
+++ b/drivers/gpu/drm/i915/display/intel_bw.c
@@ -182,7 +182,7 @@ static int mtl_read_qgv_point_info(struct drm_i915_private *dev_priv,
val2 = intel_uncore_read(&dev_priv->uncore,
MTL_MEM_SS_INFO_QGV_POINT_HIGH(point));
dclk = REG_FIELD_GET(MTL_DCLK_MASK, val);
- sp->dclk = DIV_ROUND_UP((16667 * dclk), 1000);
+ sp->dclk = (16667 * dclk + 500) / 1000;
sp->t_rp = REG_FIELD_GET(MTL_TRP_MASK, val);
sp->t_rcd = REG_FIELD_GET(MTL_TRCD_MASK, val);
--
2.34.1
next prev parent reply other threads:[~2023-04-25 20:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 20:20 [Intel-gfx] [PATCH v1 0/7] mtl: add support for pmdemand Vinod Govindapillai
2023-04-25 20:20 ` Vinod Govindapillai [this message]
2023-04-25 20:20 ` [Intel-gfx] [PATCH v1 2/7] drm/i915: store the peak bw per QGV point Vinod Govindapillai
2023-04-25 20:20 ` [Intel-gfx] [PATCH v1 3/7] drm/i915: extract intel_bw_check_qgv_points() Vinod Govindapillai
2023-04-25 20:20 ` [Intel-gfx] [PATCH v1 4/7] drm/i915: modify max_bw to return index to intel_bw_info Vinod Govindapillai
2023-04-25 22:57 ` kernel test robot
2023-04-25 20:20 ` [Intel-gfx] [PATCH v1 5/7] drm/i915/mtl: find best QGV point and configure sagv Vinod Govindapillai
2023-04-25 20:20 ` [Intel-gfx] [PATCH v1 6/7] drm/i915/mtl: Add support for PM DEMAND Vinod Govindapillai
2023-04-25 20:20 ` [Intel-gfx] [PATCH v1 7/7] drm/i915/display: provision to suppress drm_warn in intel_get_crtc_new_encoder Vinod Govindapillai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230425202056.1143994-2-vinod.govindapillai@intel.com \
--to=vinod.govindapillai@intel.com \
--cc=gustavo.souza@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox