Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tejas Upadhyay <tejas.upadhyay@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Andi Shyti <andi.shyti@intel.com>
Subject: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Use gt_err for GT info
Date: Fri, 28 Apr 2023 18:29:51 +0530	[thread overview]
Message-ID: <20230428125952.4037964-2-tejas.upadhyay@intel.com> (raw)
In-Reply-To: <20230428125952.4037964-1-tejas.upadhyay@intel.com>

It will be more informative regarding
GT if we use gt_err instead.

Cc: Andi Shyti <andi.shyti@intel.com>
Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
---
 drivers/gpu/drm/i915/gt/selftest_engine_pm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/selftest_engine_pm.c b/drivers/gpu/drm/i915/gt/selftest_engine_pm.c
index 87c94314cf67..10e556a7eac4 100644
--- a/drivers/gpu/drm/i915/gt/selftest_engine_pm.c
+++ b/drivers/gpu/drm/i915/gt/selftest_engine_pm.c
@@ -5,6 +5,7 @@
 
 #include <linux/sort.h>
 
+#include "gt/intel_gt_print.h"
 #include "i915_selftest.h"
 #include "intel_engine_regs.h"
 #include "intel_gpu_commands.h"
@@ -402,7 +403,7 @@ static int live_engine_pm(void *arg)
 
 			/* gt wakeref is async (deferred to workqueue) */
 			if (intel_gt_pm_wait_for_idle(gt)) {
-				pr_err("GT failed to idle\n");
+				gt_err(gt, "GT failed to idle\n");
 				return -EINVAL;
 			}
 		}
-- 
2.25.1


  reply	other threads:[~2023-04-28 12:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-28 12:59 [Intel-gfx] [PATCH 0/2] drm/i915: Use gt_err inplace of pr_err Tejas Upadhyay
2023-04-28 12:59 ` Tejas Upadhyay [this message]
2023-04-28 13:45   ` [Intel-gfx] [PATCH 1/2] drm/i915/gt: Use gt_err for GT info Andi Shyti
2023-04-28 12:59 ` [Intel-gfx] [PATCH 2/2] drm/i915/selftests: " Tejas Upadhyay
2023-04-28 13:46   ` Andi Shyti
2023-04-28 20:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use gt_err inplace of pr_err Patchwork
2023-04-29  5:56 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230428125952.4037964-2-tejas.upadhyay@intel.com \
    --to=tejas.upadhyay@intel.com \
    --cc=andi.shyti@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox