From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch, airlied@gmail.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
javierm@redhat.com, sam@ravnborg.org
Cc: linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org,
intel-gfx@lists.freedesktop.org, "Pan,
Xinhui" <Xinhui.Pan@amd.com>,
dri-devel@lists.freedesktop.org,
"Alex Deucher" <alexander.deucher@amd.com>,
amd-gfx@lists.freedesktop.org,
"Thomas Zimmermann" <tzimmermann@suse.de>,
linux-tegra@vger.kernel.org, freedreno@lists.freedesktop.org,
"Christian König" <christian.koenig@amd.com>,
linux-arm-kernel@lists.infradead.org
Subject: [Intel-gfx] [PATCH v3 05/12] drm/radeon: Use regular fbdev I/O helpers
Date: Mon, 22 May 2023 14:21:33 +0200 [thread overview]
Message-ID: <20230522122140.30131-6-tzimmermann@suse.de> (raw)
In-Reply-To: <20230522122140.30131-1-tzimmermann@suse.de>
Use the regular fbdev helpers for framebuffer I/O instead of DRM's
helpers. Radeon does not use damage handling, so DRM's fbdev helpers
are mere wrappers around the fbdev code.
By using fbdev helpers directly within each DRM fbdev emulation,
we can eventually remove DRM's wrapper functions entirely.
v2:
* use FB_IO_HELPERS option
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
---
drivers/gpu/drm/radeon/Kconfig | 1 +
drivers/gpu/drm/radeon/radeon_fbdev.c | 9 ++++-----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/radeon/Kconfig b/drivers/gpu/drm/radeon/Kconfig
index e19d77d58810..fe498c8af1bb 100644
--- a/drivers/gpu/drm/radeon/Kconfig
+++ b/drivers/gpu/drm/radeon/Kconfig
@@ -11,6 +11,7 @@ config DRM_RADEON
select DRM_SUBALLOC_HELPER
select DRM_TTM
select DRM_TTM_HELPER
+ select FB_IO_HELPERS if DRM_FBDEV_EMULATION
select SND_HDA_COMPONENT if SND_HDA_CORE
select POWER_SUPPLY
select HWMON
diff --git a/drivers/gpu/drm/radeon/radeon_fbdev.c b/drivers/gpu/drm/radeon/radeon_fbdev.c
index fe76e29910ef..dcabe527f9c0 100644
--- a/drivers/gpu/drm/radeon/radeon_fbdev.c
+++ b/drivers/gpu/drm/radeon/radeon_fbdev.c
@@ -24,6 +24,7 @@
* David Airlie
*/
+#include <linux/fb.h>
#include <linux/pci.h>
#include <linux/pm_runtime.h>
#include <linux/vga_switcheroo.h>
@@ -193,11 +194,9 @@ static const struct fb_ops radeon_fbdev_fb_ops = {
DRM_FB_HELPER_DEFAULT_OPS,
.fb_open = radeon_fbdev_fb_open,
.fb_release = radeon_fbdev_fb_release,
- .fb_read = drm_fb_helper_cfb_read,
- .fb_write = drm_fb_helper_cfb_write,
- .fb_fillrect = drm_fb_helper_cfb_fillrect,
- .fb_copyarea = drm_fb_helper_cfb_copyarea,
- .fb_imageblit = drm_fb_helper_cfb_imageblit,
+ .fb_fillrect = cfb_fillrect,
+ .fb_copyarea = cfb_copyarea,
+ .fb_imageblit = cfb_imageblit,
.fb_destroy = radeon_fbdev_fb_destroy,
};
--
2.40.1
next prev parent reply other threads:[~2023-05-22 12:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 12:21 [Intel-gfx] [PATCH v3 00/12] drm/fbdev: Remove DRM's helpers for fbdev I/O Thomas Zimmermann
2023-05-22 12:21 ` [Intel-gfx] [PATCH v3 01/12] fbdev: Add Kconfig options to select different fb_ops helpers Thomas Zimmermann
2023-05-22 12:21 ` [Intel-gfx] [PATCH v3 02/12] drm/armada: Use regular fbdev I/O helpers Thomas Zimmermann
2023-05-22 12:21 ` [Intel-gfx] [PATCH v3 03/12] drm/exynos: " Thomas Zimmermann
2023-05-22 12:21 ` [Intel-gfx] [PATCH v3 04/12] drm/gma500: " Thomas Zimmermann
2023-05-22 12:21 ` Thomas Zimmermann [this message]
2023-05-22 12:21 ` [Intel-gfx] [PATCH v3 06/12] drm/fbdev-dma: " Thomas Zimmermann
2023-05-22 12:21 ` [Intel-gfx] [PATCH v3 07/12] drm/msm: " Thomas Zimmermann
2023-05-22 12:21 ` [Intel-gfx] [PATCH v3 08/12] drm/omapdrm: " Thomas Zimmermann
2023-05-22 12:21 ` [Intel-gfx] [PATCH v3 09/12] drm/tegra: " Thomas Zimmermann
2023-05-22 12:21 ` [Intel-gfx] [PATCH v3 10/12] drm/fb-helper: Export helpers for marking damage areas Thomas Zimmermann
2023-05-22 12:21 ` [Intel-gfx] [PATCH v3 11/12] drm/fbdev-generic: Implement dedicated fbdev I/O helpers Thomas Zimmermann
2023-05-22 13:20 ` [Intel-gfx] [Freedreno] " Dmitry Baryshkov
2023-05-22 18:46 ` Thomas Zimmermann
2023-05-23 19:19 ` Thomas Zimmermann
2023-05-22 12:21 ` [Intel-gfx] [PATCH v3 12/12] drm/i915: " Thomas Zimmermann
2023-05-22 19:06 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/fbdev: Remove DRM's helpers for fbdev I/O (rev3) Patchwork
2023-05-23 3:08 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230522122140.30131-6-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox