From: Sam Ravnborg <sam@ravnborg.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: freedreno@lists.freedesktop.org,
linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org,
linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
javierm@redhat.com, dri-devel@lists.freedesktop.org,
mripard@kernel.org, daniel@ffwll.ch, linux-tegra@vger.kernel.org,
airlied@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [Intel-gfx] [PATCH v4 02/13] fbdev: Add initializer macros for struct fb_ops
Date: Mon, 29 May 2023 21:23:47 +0200 [thread overview]
Message-ID: <20230529192347.GB1370714@ravnborg.org> (raw)
In-Reply-To: <20230524092150.11776-3-tzimmermann@suse.de>
On Wed, May 24, 2023 at 11:21:39AM +0200, Thomas Zimmermann wrote:
> For framebuffers in I/O and system memory, add macros that set
> struct fb_ops to the respective callback functions.
>
> For deferred I/O, add macros that generate callback functions with
> damage handling. Add initializer macros that set struct fb_ops to
> the generated callbacks.
>
> These macros can remove a lot boilerplate code from fbdev drivers.
> The drivers are supposed to use the macro that is required for its
> framebuffer. Each macro is split into smaller helpers, so that
> drivers with non-standard callbacks can pick and customize callbacks
> as needed. There are individual helper macros for read/write, mmap
> and drawing.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
I am not a fan of public functions/macros names __something.
But I see it used in so many places, so maybe it is just me.
And everything looks consistent, so OK.
With the white space issues fixed:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
next prev parent reply other threads:[~2023-05-29 19:23 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 9:21 [Intel-gfx] [PATCH v4 00/13] drm/fbdev: Remove DRM's helpers for fbdev I/O Thomas Zimmermann
2023-05-24 9:21 ` [Intel-gfx] [PATCH v4 01/13] fbdev: Add Kconfig options to select different fb_ops helpers Thomas Zimmermann
2023-05-24 20:46 ` [Intel-gfx] [v4, " Sui Jingfeng
2023-05-29 19:17 ` [Intel-gfx] [PATCH v4 " Sam Ravnborg
2023-05-24 9:21 ` [Intel-gfx] [PATCH v4 02/13] fbdev: Add initializer macros for struct fb_ops Thomas Zimmermann
2023-05-24 20:57 ` [Intel-gfx] [v4, " Sui Jingfeng
2023-05-26 12:38 ` Thomas Zimmermann
2023-05-29 19:23 ` Sam Ravnborg [this message]
2023-05-24 9:21 ` [Intel-gfx] [PATCH v4 03/13] drm/armada: Use regular fbdev I/O helpers Thomas Zimmermann
2023-05-29 19:24 ` Sam Ravnborg
2023-05-24 9:21 ` [Intel-gfx] [PATCH v4 04/13] drm/exynos: " Thomas Zimmermann
2023-05-24 9:21 ` [Intel-gfx] [PATCH v4 05/13] drm/gma500: " Thomas Zimmermann
2023-05-24 9:21 ` [Intel-gfx] [PATCH v4 06/13] drm/radeon: " Thomas Zimmermann
2023-05-24 9:21 ` [Intel-gfx] [PATCH v4 07/13] drm/fbdev-dma: " Thomas Zimmermann
2023-05-24 9:21 ` [Intel-gfx] [PATCH v4 08/13] drm/msm: " Thomas Zimmermann
2023-05-24 9:21 ` [Intel-gfx] [PATCH v4 09/13] drm/omapdrm: " Thomas Zimmermann
2023-05-24 9:21 ` [Intel-gfx] [PATCH v4 10/13] drm/tegra: " Thomas Zimmermann
2023-05-24 9:21 ` [Intel-gfx] [PATCH v4 11/13] drm/fb-helper: Export helpers for marking damage areas Thomas Zimmermann
2023-05-29 19:38 ` Sam Ravnborg
2023-05-24 9:21 ` [Intel-gfx] [PATCH v4 12/13] drm/fbdev-generic: Implement dedicated fbdev I/O helpers Thomas Zimmermann
2023-05-24 20:23 ` [Intel-gfx] [v4, " Sui Jingfeng
2023-05-26 12:44 ` Thomas Zimmermann
2023-05-25 2:46 ` Sui Jingfeng
2023-05-24 9:21 ` [Intel-gfx] [PATCH v4 13/13] drm/i915: " Thomas Zimmermann
2023-05-24 21:25 ` [Intel-gfx] [v4, " Sui Jingfeng
2023-05-29 19:36 ` [Intel-gfx] [PATCH v4 " Sam Ravnborg
2023-05-30 4:02 ` Sui Jingfeng
2023-05-30 7:12 ` Thomas Zimmermann
2023-05-30 15:37 ` Sam Ravnborg
2023-05-29 19:41 ` Sam Ravnborg
2023-05-24 19:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/fbdev: Remove DRM's helpers for fbdev I/O (rev4) Patchwork
2023-05-24 19:26 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-05-24 19:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-05-25 12:44 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-05-29 19:37 ` [Intel-gfx] [PATCH v4 00/13] drm/fbdev: Remove DRM's helpers for fbdev I/O Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230529192347.GB1370714@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox