From: Vinod Govindapillai <vinod.govindapillai@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v12 3/7] drm/i915: store the peak bw per QGV point
Date: Thu, 1 Jun 2023 19:03:46 +0300 [thread overview]
Message-ID: <20230601160350.43888-4-vinod.govindapillai@intel.com> (raw)
In-Reply-To: <20230601160350.43888-1-vinod.govindapillai@intel.com>
In MTL onwards, pcode locks the GV point based on the peak BW
of a QGV point. So store the peak BW of all the QGV points.
v2: use DIV_ROUND_CLOSEST() for the peakBW calculation
Bspec: 64636
Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
drivers/gpu/drm/i915/display/intel_bw.c | 8 ++++++--
drivers/gpu/drm/i915/display/intel_display_core.h | 2 ++
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
index 61b3babf2d83..b792d307e9d5 100644
--- a/drivers/gpu/drm/i915/display/intel_bw.c
+++ b/drivers/gpu/drm/i915/display/intel_bw.c
@@ -534,10 +534,14 @@ static int tgl_get_bw_info(struct drm_i915_private *dev_priv, const struct intel
bi->deratedbw[j] = min(maxdebw,
bw * (100 - sa->derating) / 100);
+ bi->peakbw[j] = DIV_ROUND_CLOSEST(sp->dclk *
+ num_channels *
+ qi.channel_width, 8);
drm_dbg_kms(&dev_priv->drm,
- "BW%d / QGV %d: num_planes=%d deratedbw=%u\n",
- i, j, bi->num_planes, bi->deratedbw[j]);
+ "BW%d / QGV %d: num_planes=%d deratedbw=%u peakbw: %u\n",
+ i, j, bi->num_planes, bi->deratedbw[j],
+ bi->peakbw[j]);
}
for (j = 0; j < qi.num_psf_points; j++) {
diff --git a/drivers/gpu/drm/i915/display/intel_display_core.h b/drivers/gpu/drm/i915/display/intel_display_core.h
index 2209811eb29e..dd8e08c8598f 100644
--- a/drivers/gpu/drm/i915/display/intel_display_core.h
+++ b/drivers/gpu/drm/i915/display/intel_display_core.h
@@ -314,6 +314,8 @@ struct intel_display {
unsigned int deratedbw[I915_NUM_QGV_POINTS];
/* for each PSF GV point */
unsigned int psf_bw[I915_NUM_PSF_GV_POINTS];
+ /* Peak BW for each QGV point */
+ unsigned int peakbw[I915_NUM_QGV_POINTS];
u8 num_qgv_points;
u8 num_psf_gv_points;
u8 num_planes;
--
2.34.1
next prev parent reply other threads:[~2023-06-01 16:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 16:03 [Intel-gfx] [PATCH v12 0/7] mtl: add support for pmdemand Vinod Govindapillai
2023-06-01 16:03 ` [Intel-gfx] [PATCH v12 1/7] drm/i915: fix the derating percentage for MTL Vinod Govindapillai
2023-06-01 16:03 ` [Intel-gfx] [PATCH v12 2/7] drm/i915: update the QGV point frequency calculations Vinod Govindapillai
2023-06-01 16:03 ` Vinod Govindapillai [this message]
2023-06-01 16:03 ` [Intel-gfx] [PATCH v12 4/7] drm/i915: extract intel_bw_check_qgv_points() Vinod Govindapillai
2023-06-01 16:03 ` [Intel-gfx] [PATCH v12 5/7] drm/i915: modify max_bw to return index to intel_bw_info Vinod Govindapillai
2023-06-01 16:03 ` [Intel-gfx] [PATCH v12 6/7] drm/i915/mtl: find the best QGV point for the SAGV configuration Vinod Govindapillai
2023-06-05 9:49 ` Imre Deak
2023-06-05 9:59 ` Govindapillai, Vinod
2023-06-01 16:03 ` [Intel-gfx] [PATCH v12 7/7] drm/i915/mtl: Add support for PM DEMAND Vinod Govindapillai
2023-06-05 10:09 ` Imre Deak
2023-06-01 21:53 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for mtl: add support for pmdemand (rev12) Patchwork
2023-06-01 21:53 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-06-01 22:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-06-04 0:50 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230601160350.43888-4-vinod.govindapillai@intel.com \
--to=vinod.govindapillai@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox