Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v4 2/2] i915/perf: Do not add ggtt offset to hw_tail
Date: Mon,  5 Jun 2023 12:39:23 -0700	[thread overview]
Message-ID: <20230605193923.1836048-3-umesh.nerlige.ramappa@intel.com> (raw)
In-Reply-To: <20230605193923.1836048-1-umesh.nerlige.ramappa@intel.com>

ggtt offset for hw_tail is not required for the calculations, so drop
it.

Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
 drivers/gpu/drm/i915/i915_perf.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
index a8d43bf1f6d5..0a111b281578 100644
--- a/drivers/gpu/drm/i915/i915_perf.c
+++ b/drivers/gpu/drm/i915/i915_perf.c
@@ -565,7 +565,7 @@ static bool oa_buffer_check_unlocked(struct i915_perf_stream *stream)
 	partial_report_size %= report_size;
 
 	/* Subtract partial amount off the tail */
-	hw_tail = gtt_offset + OA_TAKEN(hw_tail, partial_report_size);
+	hw_tail = OA_TAKEN(hw_tail, partial_report_size);
 
 	/* NB: The head we observe here might effectively be a little
 	 * out of date. If a read() is in progress, the head could be
@@ -574,7 +574,6 @@ static bool oa_buffer_check_unlocked(struct i915_perf_stream *stream)
 	head = stream->oa_buffer.head - gtt_offset;
 	read_tail = stream->oa_buffer.tail - gtt_offset;
 
-	hw_tail -= gtt_offset;
 	tail = hw_tail;
 
 	/* Walk the stream backward until we find a report with report
-- 
2.36.1


  parent reply	other threads:[~2023-06-05 19:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-05 19:39 [Intel-gfx] [PATCH v4 0/2] Avoid reading OA reports before they land Umesh Nerlige Ramappa
2023-06-05 19:39 ` [Intel-gfx] [PATCH v4 1/2] i915/perf: Drop the aging_tail logic in perf OA Umesh Nerlige Ramappa
2023-06-05 19:39 ` Umesh Nerlige Ramappa [this message]
2023-06-05 23:25 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Avoid reading OA reports before they land Patchwork
2023-06-05 23:44 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-06-07 19:25   ` Umesh Nerlige Ramappa
2023-06-07  1:30 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Avoid reading OA reports before they land (rev2) Patchwork
2023-06-07  1:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-06-07 17:40 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-06-07 19:44   ` Umesh Nerlige Ramappa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230605193923.1836048-3-umesh.nerlige.ramappa@intel.com \
    --to=umesh.nerlige.ramappa@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox