From: Arun R Murthy <arun.r.murthy@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH] drm/i915/display/dp: Add fallback on LT failure for DP2.0
Date: Tue, 20 Jun 2023 13:14:00 +0530 [thread overview]
Message-ID: <20230620074400.1054530-1-arun.r.murthy@intel.com> (raw)
For DP2.0 as per the Spec on LT failure we need to reduce the lane count
if the lane count is not equal to 1. If lane count is 1 then need to
retry with reducing the link rate.
Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 20 ++++++++++++++++++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 54ddc953e5bc..2b12ca45596d 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -657,8 +657,20 @@ int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
"Retrying Link training for eDP with same parameters\n");
return 0;
}
- intel_dp->max_link_rate = intel_dp_common_rate(intel_dp, index - 1);
- intel_dp->max_link_lane_count = lane_count;
+ if (intel_dp->dpcd[DP_MAIN_LINK_CHANNEL_CODING] & DP_CAP_ANSI_128B132B) {
+ if (lane_count > 1) {
+ /* Reduce the lane count */
+ intel_dp->max_link_lane_count = lane_count >> 1;
+ intel_dp->max_link_rate = intel_dp_common_rate(intel_dp, index);
+ } else {
+ /* Reduce the link rate */
+ intel_dp->max_link_rate = intel_dp_common_rate(intel_dp, index - 1);
+ intel_dp->max_link_lane_count = intel_dp_max_common_lane_count(intel_dp);
+ }
+ } else {
+ intel_dp->max_link_rate = intel_dp_common_rate(intel_dp, index - 1);
+ intel_dp->max_link_lane_count = lane_count;
+ }
} else if (lane_count > 1) {
if (intel_dp_is_edp(intel_dp) &&
!intel_dp_can_link_train_fallback_for_edp(intel_dp,
@@ -675,6 +687,10 @@ int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
return -1;
}
+ drm_dbg_kms(&i915->drm,
+ "Retrying Link training with link rate %d and lane count %d\n",
+ intel_dp->max_link_rate, intel_dp->max_link_lane_count);
+
return 0;
}
--
2.25.1
next reply other threads:[~2023-06-20 7:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 7:44 Arun R Murthy [this message]
2023-06-20 9:05 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display/dp: Add fallback on LT failure for DP2.0 Patchwork
2023-06-20 9:24 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-06-20 11:05 ` [Intel-gfx] [PATCH] " Kandpal, Suraj
2023-06-20 12:25 ` Murthy, Arun R
2023-06-20 13:09 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
2023-06-20 13:55 ` [Intel-gfx] [PATCH] " Jani Nikula
2023-06-26 5:41 ` Murthy, Arun R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230620074400.1054530-1-arun.r.murthy@intel.com \
--to=arun.r.murthy@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox