From: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 1/1] drm/i915/display: HDMI2.0/DP1p62Gbps skew violation when there is skew between DL PCLK
Date: Tue, 27 Jun 2023 21:04:51 +0530 [thread overview]
Message-ID: <20230627153451.2834196-2-mitulkumar.ajitkumar.golani@intel.com> (raw)
In-Reply-To: <20230627153451.2834196-1-mitulkumar.ajitkumar.golani@intel.com>
When doing type-C PHY voltage swing programming for HDMI and
DP 1.62Gbps, program DKLP_PCS_GLUE_TX_DPCNTL2[loadgen_sharing_pmd_disable]
to '1'. For other DP frequencies, program
DKLP_PCS_GLUE_TX_DPCNTL2[loadgen_sharing_pmd_disable] to '0'.
This Workaround is specific to Display Version 13
Wa_15010727533
Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
---
drivers/gpu/drm/i915/display/intel_ddi.c | 13 +++++++++++++
drivers/gpu/drm/i915/i915_reg.h | 6 ++++++
2 files changed, 19 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 61722556bb47..5a6f048f4f1c 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -1362,6 +1362,19 @@ static void tgl_dkl_phy_set_signal_levels(struct intel_encoder *encoder,
intel_dkl_phy_rmw(dev_priv, DKL_TX_DPCNTL2(tc_port, ln),
DKL_TX_DP20BITMODE, 0);
+ if (DISPLAY_VER(dev_priv) == 13) {
+ if ((crtc_state->port_clock == 594000 &&
+ intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI)) ||
+ (crtc_state->port_clock == 162000 &&
+ intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DP))) {
+ intel_de_rmw(dev_priv, DKLP_TX_DPCNTL2(tc_port),
+ LOADGEN_SHARING_PMD_DISABLE, 1);
+ } else {
+ intel_de_rmw(dev_priv, DKLP_TX_DPCNTL2(tc_port),
+ LOADGEN_SHARING_PMD_DISABLE, 0);
+ }
+ }
+
if (IS_ALDERLAKE_P(dev_priv)) {
u32 val;
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index dcf64e32cd54..5487301d4ad3 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -6663,4 +6663,10 @@ enum skl_power_gate {
#define MTL_MEDIA_GSI_BASE 0x380000
+#define _DKLP_PCS_GLUE_TX_DPCNTL2 0xB68
+#define LOADGEN_SHARING_PMD_DISABLE REG_BIT(2)
+#define DKLP_TX_DPCNTL2(tc_port) _MMIO(_PORT(tc_port, \
+ _DKL_PHY1_BASE, \
+ _DKL_PHY2_BASE) + \
+ _DKLP_PCS_GLUE_TX_DPCNTL2)
#endif /* _I915_REG_H_ */
--
2.25.1
next prev parent reply other threads:[~2023-06-27 15:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 15:34 [Intel-gfx] [PATCH 0/1] HDMI 2.0/DP1p62Gbps skew violation when there is skew between DL PCLK Mitul Golani
2023-06-27 15:34 ` Mitul Golani [this message]
2023-06-27 18:12 ` [Intel-gfx] [PATCH 1/1] drm/i915/display: HDMI2.0/DP1p62Gbps " Imre Deak
2023-06-27 22:00 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for HDMI 2.0/DP1p62Gbps " Patchwork
2023-06-27 22:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-06-28 16:42 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230627153451.2834196-2-mitulkumar.ajitkumar.golani@intel.com \
--to=mitulkumar.ajitkumar.golani@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox