Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 0/2] Calculate CDCLK more properly when DSC is enabled
Date: Tue,  4 Jul 2023 13:31:05 +0300	[thread overview]
Message-ID: <20230704103107.11237-1-stanislav.lisovskiy@intel.com> (raw)

We need to properly estimate our available BW when DSC is enabled because
this can lead both to need in increasing or decresing CDCLK.
Each DSC engine can process only single pixel at a time thus if only
single DSC engine is enabled, CDCLK is obliged to be equal to pixel clock
(while in non-compressed case it can be usualy lower)
However if we have 2 DSC engines CDCLK can be ~pixel clock / 2 and so on.
Lets do the estimation more properly based on amount of VDSC engines used.
That most likely is going to fix some FIFO underruns, we are currently
having.

Stanislav Lisovskiy (2):
  drm/i915: Add helper function for getting number of VDSC engines
  drm/i915: Don't rely that 2 VDSC engines are always enough for pixel
    rate

 drivers/gpu/drm/i915/display/intel_cdclk.c | 13 +++++++++++--
 drivers/gpu/drm/i915/display/intel_vdsc.c  | 15 +++++++++++----
 drivers/gpu/drm/i915/display/intel_vdsc.h  |  1 +
 3 files changed, 23 insertions(+), 6 deletions(-)

-- 
2.37.3


             reply	other threads:[~2023-07-04 10:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-04 10:31 Stanislav Lisovskiy [this message]
2023-07-04 10:31 ` [Intel-gfx] [PATCH 1/2] drm/i915: Add helper function for getting number of VDSC engines Stanislav Lisovskiy
2023-07-04 12:17   ` Jani Nikula
2023-07-04 10:31 ` [Intel-gfx] [PATCH 2/2] drm/i915: Don't rely that 2 VDSC engines are always enough for pixel rate Stanislav Lisovskiy
2023-07-04 11:58 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Calculate CDCLK more properly when DSC is enabled Patchwork
2023-07-04 11:58 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-07-04 12:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-07-04 16:10 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2023-07-04 13:17 [Intel-gfx] [PATCH 0/2] " Stanislav Lisovskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230704103107.11237-1-stanislav.lisovskiy@intel.com \
    --to=stanislav.lisovskiy@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox