From: Andi Shyti <andi.shyti@kernel.org>
To: Nirmoy Das <nirmoy.das@linux.intel.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>,
Jonathan Cavitt <jonathan.cavitt@intel.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
Matt Roper <matthew.d.roper@intel.com>
Subject: Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/gt: Support aux invalidation on all engines
Date: Wed, 12 Jul 2023 23:58:00 +0200 [thread overview]
Message-ID: <20230712215800.nwqk4hjbpplbfvs4@intel.intel> (raw)
In-Reply-To: <6693d0f0-d9fe-464e-0d2e-7d19804e23b8@linux.intel.com>
Hi Nirmoy,
> > @@ -301,11 +336,7 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
> > cs = gen8_emit_pipe_control(cs, flags, LRC_PPHWSP_SCRATCH_ADDR);
> > - if (!HAS_FLAT_CCS(rq->engine->i915)) {
> > - /* hsdes: 1809175790 */
>
> We should keep this reference which is getting removed by this patch.
Correct! Will add it back in the proper function. Thanks!
Andi
next prev parent reply other threads:[~2023-07-12 21:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 9:43 [Intel-gfx] [PATCH v2 0/4] Update AUX invalidation sequence Andi Shyti
2023-06-27 9:43 ` [Intel-gfx] [PATCH v2 1/4] drm/i915/gt: Cleanup aux invalidation registers Andi Shyti
2023-07-12 13:51 ` Nirmoy Das
2023-06-27 9:43 ` [Intel-gfx] [PATCH v2 2/4] drm/i915/gt: Ensure memory quiesced before invalidation Andi Shyti
2023-07-12 14:17 ` Nirmoy Das
2023-07-12 15:39 ` Cavitt, Jonathan
2023-07-13 9:31 ` Nirmoy Das
2023-07-13 12:31 ` Andi Shyti
2023-07-13 14:12 ` Nirmoy Das
2023-07-13 14:23 ` Cavitt, Jonathan
2023-07-14 10:24 ` Nirmoy Das
2023-06-27 9:43 ` [Intel-gfx] [PATCH v2 3/4] drm/i915/gt: Poll aux invalidation register bit on invalidation Andi Shyti
2023-07-12 14:24 ` Nirmoy Das
2023-06-27 9:43 ` [Intel-gfx] [PATCH v2 4/4] drm/i915/gt: Support aux invalidation on all engines Andi Shyti
2023-07-12 14:26 ` Nirmoy Das
2023-07-12 21:58 ` Andi Shyti [this message]
2023-06-27 15:53 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Update AUX invalidation sequence (rev2) Patchwork
2023-06-27 16:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-06-28 5:16 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230712215800.nwqk4hjbpplbfvs4@intel.intel \
--to=andi.shyti@kernel.org \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jonathan.cavitt@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=nirmoy.das@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox