From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: [Intel-gfx] [CI 2/4] drm/i915: Record default rps threshold values
Date: Mon, 17 Jul 2023 17:40:11 +0100 [thread overview]
Message-ID: <20230717164013.826614-2-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <20230717164013.826614-1-tvrtko.ursulin@linux.intel.com>
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Record the default values as preparation for exposing the sysfs controls.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@kernel.org>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
---
drivers/gpu/drm/i915/gt/intel_gt_types.h | 3 +++
drivers/gpu/drm/i915/gt/intel_rps.c | 2 ++
2 files changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_types.h b/drivers/gpu/drm/i915/gt/intel_gt_types.h
index f08c2556aa25..1b22d7a50665 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_types.h
+++ b/drivers/gpu/drm/i915/gt/intel_gt_types.h
@@ -83,6 +83,9 @@ enum intel_submission_method {
struct gt_defaults {
u32 min_freq;
u32 max_freq;
+
+ u8 rps_up_threshold;
+ u8 rps_down_threshold;
};
enum intel_gt_type {
diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c
index 20d44549f65e..69847f919586 100644
--- a/drivers/gpu/drm/i915/gt/intel_rps.c
+++ b/drivers/gpu/drm/i915/gt/intel_rps.c
@@ -2018,7 +2018,9 @@ void intel_rps_init(struct intel_rps *rps)
/* Set default thresholds in % */
rps->power.up_threshold = 95;
+ rps_to_gt(rps)->defaults.rps_up_threshold = rps->power.up_threshold;
rps->power.down_threshold = 85;
+ rps_to_gt(rps)->defaults.rps_down_threshold = rps->power.down_threshold;
/* Finally allow us to boost to max by default */
rps->boost_freq = rps->max_freq;
--
2.39.2
next prev parent reply other threads:[~2023-07-17 16:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 16:40 [Intel-gfx] [CI 1/4] drm/i915: Move setting of rps thresholds to init Tvrtko Ursulin
2023-07-17 16:40 ` Tvrtko Ursulin [this message]
2023-07-17 16:40 ` [Intel-gfx] [CI 3/4] drm/i915: Add helpers for managing rps thresholds Tvrtko Ursulin
2023-07-17 16:40 ` [Intel-gfx] [CI 4/4] drm/i915: Expose RPS thresholds in sysfs Tvrtko Ursulin
2023-07-17 18:36 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/4] drm/i915: Move setting of rps thresholds to init Patchwork
2023-07-17 18:36 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-07-17 18:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-07-17 23:46 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-07-18 8:05 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/4] drm/i915: Move setting of rps thresholds to init (rev2) Patchwork
2023-07-18 8:05 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-07-18 8:29 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-07-18 10:23 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-07-18 15:43 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/4] drm/i915: Move setting of rps thresholds to init (rev3) Patchwork
2023-07-18 15:43 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-07-18 15:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-07-18 21:39 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-06-05 9:45 [Intel-gfx] [CI 1/4] drm/i915: Move setting of rps thresholds to init Tvrtko Ursulin
2023-06-05 9:45 ` [Intel-gfx] [CI 2/4] drm/i915: Record default rps threshold values Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230717164013.826614-2-tvrtko.ursulin@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox