Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH] drm/i915: Use the i915_vma_flush_writes helper
Date: Fri, 21 Jul 2023 14:07:41 +0100	[thread overview]
Message-ID: <20230721130741.1306563-1-tvrtko.ursulin@linux.intel.com> (raw)

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

We can use the existing helper in flush_write_domain() and save some lines
of code.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 drivers/gpu/drm/i915/gem/i915_gem_domain.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_domain.c b/drivers/gpu/drm/i915/gem/i915_gem_domain.c
index dfaaa8b66ac3..ffddec1d2a76 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_domain.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_domain.c
@@ -68,10 +68,8 @@ flush_write_domain(struct drm_i915_gem_object *obj, unsigned int flush_domains)
 	switch (obj->write_domain) {
 	case I915_GEM_DOMAIN_GTT:
 		spin_lock(&obj->vma.lock);
-		for_each_ggtt_vma(vma, obj) {
-			if (i915_vma_unset_ggtt_write(vma))
-				intel_gt_flush_ggtt_writes(vma->vm->gt);
-		}
+		for_each_ggtt_vma(vma, obj)
+			i915_vma_flush_writes(vma);
 		spin_unlock(&obj->vma.lock);
 
 		i915_gem_object_flush_frontbuffer(obj, ORIGIN_CPU);
-- 
2.39.2


             reply	other threads:[~2023-07-21 13:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-21 13:07 Tvrtko Ursulin [this message]
2023-07-21 13:54 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Use the i915_vma_flush_writes helper Patchwork
2023-07-21 15:53 ` [Intel-gfx] [PATCH] " Sripada, Radhakrishna
2023-07-24 13:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use the i915_vma_flush_writes helper (rev2) Patchwork
2023-07-24 19:12 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-07-25 12:47 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use the i915_vma_flush_writes helper (rev3) Patchwork
2023-07-25 13:29 ` [Intel-gfx] [PATCH] drm/i915: Use the i915_vma_flush_writes helper Andi Shyti
2023-07-25 17:52 ` [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Use the i915_vma_flush_writes helper (rev3) Patchwork
2023-07-26  9:51 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Use the i915_vma_flush_writes helper (rev4) Patchwork
2023-07-26 10:48 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Use the i915_vma_flush_writes helper (rev5) Patchwork
2023-07-26 11:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use the i915_vma_flush_writes helper (rev6) Patchwork
2023-07-26 13:18 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230721130741.1306563-1-tvrtko.ursulin@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox