From: Jim Cromie <jim.cromie@gmail.com>
To: daniel@ffwll.ch, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org
Cc: Jim Cromie <jim.cromie@gmail.com>,
Edmund Dea <edmund.j.dea@intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Anitha Chrisanthus <anitha.chrisanthus@intel.com>,
David Airlie <airlied@gmail.com>
Subject: [Intel-gfx] [PATCH 1/5] drm_dbg: add trailing newlines to remaining callsites
Date: Sun, 30 Jul 2023 15:57:50 -0600 [thread overview]
Message-ID: <20230730215758.54010-2-jim.cromie@gmail.com> (raw)
In-Reply-To: <20230730215758.54010-1-jim.cromie@gmail.com>
All callers should uniformly include a trailing newline, the vast
majority already do: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the
remainders, in this and next commits (split for easy acks).
No functional changes.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
drivers/gpu/drm/kmb/kmb_crtc.c | 10 +++++-----
drivers/gpu/drm/kmb/kmb_plane.c | 6 +++---
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/kmb/kmb_crtc.c b/drivers/gpu/drm/kmb/kmb_crtc.c
index 647872f65bff..a58baf25322d 100644
--- a/drivers/gpu/drm/kmb/kmb_crtc.c
+++ b/drivers/gpu/drm/kmb/kmb_crtc.c
@@ -94,7 +94,7 @@ static void kmb_crtc_set_mode(struct drm_crtc *crtc,
vm.hback_porch = 0;
vm.hsync_len = 28;
- drm_dbg(dev, "%s : %dactive height= %d vbp=%d vfp=%d vsync-w=%d h-active=%d h-bp=%d h-fp=%d hsync-l=%d",
+ drm_dbg(dev, "%s : %dactive height= %d vbp=%d vfp=%d vsync-w=%d h-active=%d h-bp=%d h-fp=%d hsync-l=%d\n",
__func__, __LINE__,
m->crtc_vdisplay, vm.vback_porch, vm.vfront_porch,
vm.vsync_len, m->crtc_hdisplay, vm.hback_porch,
@@ -194,24 +194,24 @@ static enum drm_mode_status
int vfp = mode->vsync_start - mode->vdisplay;
if (mode->vdisplay < KMB_CRTC_MAX_HEIGHT) {
- drm_dbg(dev, "height = %d less than %d",
+ drm_dbg(dev, "height = %d less than %d\n",
mode->vdisplay, KMB_CRTC_MAX_HEIGHT);
return MODE_BAD_VVALUE;
}
if (mode->hdisplay < KMB_CRTC_MAX_WIDTH) {
- drm_dbg(dev, "width = %d less than %d",
+ drm_dbg(dev, "width = %d less than %d\n",
mode->hdisplay, KMB_CRTC_MAX_WIDTH);
return MODE_BAD_HVALUE;
}
refresh = drm_mode_vrefresh(mode);
if (refresh < KMB_MIN_VREFRESH || refresh > KMB_MAX_VREFRESH) {
- drm_dbg(dev, "refresh = %d less than %d or greater than %d",
+ drm_dbg(dev, "refresh = %d less than %d or greater than %d\n",
refresh, KMB_MIN_VREFRESH, KMB_MAX_VREFRESH);
return MODE_BAD;
}
if (vfp < KMB_CRTC_MIN_VFP) {
- drm_dbg(dev, "vfp = %d less than %d", vfp, KMB_CRTC_MIN_VFP);
+ drm_dbg(dev, "vfp = %d less than %d\n", vfp, KMB_CRTC_MIN_VFP);
return MODE_BAD;
}
diff --git a/drivers/gpu/drm/kmb/kmb_plane.c b/drivers/gpu/drm/kmb/kmb_plane.c
index 9e0562aa2bcb..308bd1cb50c8 100644
--- a/drivers/gpu/drm/kmb/kmb_plane.c
+++ b/drivers/gpu/drm/kmb/kmb_plane.c
@@ -78,7 +78,7 @@ static unsigned int check_pixel_format(struct drm_plane *plane, u32 format)
* plane configuration is not supported.
*/
if (init_disp_cfg.format && init_disp_cfg.format != format) {
- drm_dbg(&kmb->drm, "Cannot change format after initial plane configuration");
+ drm_dbg(&kmb->drm, "Cannot change format after initial plane configuration\n");
return -EINVAL;
}
for (i = 0; i < plane->format_count; i++) {
@@ -124,7 +124,7 @@ static int kmb_plane_atomic_check(struct drm_plane *plane,
if ((init_disp_cfg.width && init_disp_cfg.height) &&
(init_disp_cfg.width != fb->width ||
init_disp_cfg.height != fb->height)) {
- drm_dbg(&kmb->drm, "Cannot change plane height or width after initial configuration");
+ drm_dbg(&kmb->drm, "Cannot change plane height or width after initial configuration\n");
return -EINVAL;
}
can_position = (plane->type == DRM_PLANE_TYPE_OVERLAY);
@@ -375,7 +375,7 @@ static void kmb_plane_atomic_update(struct drm_plane *plane,
spin_lock_irq(&kmb->irq_lock);
if (kmb->kmb_under_flow || kmb->kmb_flush_done) {
spin_unlock_irq(&kmb->irq_lock);
- drm_dbg(&kmb->drm, "plane_update:underflow!!!! returning");
+ drm_dbg(&kmb->drm, "plane_update:underflow!!!! returning\n");
return;
}
spin_unlock_irq(&kmb->irq_lock);
--
2.41.0
next prev parent reply other threads:[~2023-07-30 21:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-30 21:57 [Intel-gfx] [PATCH 0/5] drm_dbg: add trailing newlines where missing Jim Cromie
2023-07-30 21:57 ` Jim Cromie [this message]
2023-07-30 21:57 ` [Intel-gfx] [PATCH 2/5] drm_dbg: add trailing newlines Jim Cromie
2023-07-30 21:57 ` [Intel-gfx] [PATCH 3/5] " Jim Cromie
2023-07-30 21:57 ` [Intel-gfx] [PATCH 4/5] " Jim Cromie
2023-07-30 21:57 ` [Intel-gfx] [PATCH 5/5] " Jim Cromie
2023-07-30 22:22 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm_dbg: add trailing newlines where missing Patchwork
2023-07-30 22:22 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-07-30 22:33 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-07-30 23:52 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230730215758.54010-2-jim.cromie@gmail.com \
--to=jim.cromie@gmail.com \
--cc=airlied@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=anitha.chrisanthus@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=edmund.j.dea@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox