From: Jonathan Cavitt <jonathan.cavitt@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: chris.p.wilson@linux.intel.com, jonathan.cavitt@intel.com,
andi.shyti@intel.com
Subject: [Intel-gfx] [PATCH 1/1] drm/i915/gt: Remove interruptible flag from wait_for_space
Date: Fri, 25 Aug 2023 15:01:13 -0700 [thread overview]
Message-ID: <20230825220113.2273092-2-jonathan.cavitt@intel.com> (raw)
In-Reply-To: <20230825220113.2273092-1-jonathan.cavitt@intel.com>
When performing the i915_request_wait in wait_for_space, which itself is
called by intel_ring_begin, we do not need to apply the
I915_TASK_INTERRUPTIBLE flag. So, remove it.
Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
---
drivers/gpu/drm/i915/gt/intel_ring.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_ring.c b/drivers/gpu/drm/i915/gt/intel_ring.c
index 59da4b7bd262..73deac91a037 100644
--- a/drivers/gpu/drm/i915/gt/intel_ring.c
+++ b/drivers/gpu/drm/i915/gt/intel_ring.c
@@ -214,9 +214,7 @@ wait_for_space(struct intel_ring *ring,
if (GEM_WARN_ON(&target->link == &tl->requests))
return -ENOSPC;
- timeout = i915_request_wait(target,
- I915_WAIT_INTERRUPTIBLE,
- MAX_SCHEDULE_TIMEOUT);
+ timeout = i915_request_wait(target, 0, MAX_SCHEDULE_TIMEOUT);
if (timeout < 0)
return timeout;
--
2.25.1
next prev parent reply other threads:[~2023-08-25 22:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 22:01 [Intel-gfx] [PATCH 0/1] drm/i915/gt: Remove interruptible flag from wait_for_space Jonathan Cavitt
2023-08-25 22:01 ` Jonathan Cavitt [this message]
2023-08-25 22:47 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2023-08-25 23:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-08-26 15:36 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230825220113.2273092-2-jonathan.cavitt@intel.com \
--to=jonathan.cavitt@intel.com \
--cc=andi.shyti@intel.com \
--cc=chris.p.wilson@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox