From: Jim Cromie <jim.cromie@gmail.com>
To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
daniel.vetter@ffwll.ch, Chris Wilson <chris@chris-wilson.co.uk>,
Andrzej Hajda <andrzej.hajda@intel.com>,
David Airlie <airlied@gmail.com>,
Rob Clark <robdclark@chromium.org>,
Matthew Auld <matthew.auld@intel.com>,
jani.nikula@intel.com, seanpaul@chromium.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Jim Cromie <jim.cromie@gmail.com>,
daniel@ffwll.ch
Subject: [Intel-gfx] [PATCH v2 3/6] drm_dbg: add trailing newlines to msgs
Date: Sun, 3 Sep 2023 12:46:00 -0600 [thread overview]
Message-ID: <20230903184607.272198-4-jim.cromie@gmail.com> (raw)
In-Reply-To: <20230903184607.272198-1-jim.cromie@gmail.com>
By at least strong convention, a print-buffer's trailing newline says
"message complete, send it". The exception (no TNL, followed by a call
to pr_cont) proves the general rule.
Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG,
1288 drm_dbg. Clean up the remainders, in maintainer sized chunks.
No functional changes.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 090f242e610c..0a196348e2d1 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -4171,7 +4171,7 @@ static int intel_ddi_compute_config_late(struct intel_encoder *encoder,
struct drm_connector *connector = conn_state->connector;
u8 port_sync_transcoders = 0;
- drm_dbg_kms(&i915->drm, "[ENCODER:%d:%s] [CRTC:%d:%s]",
+ drm_dbg_kms(&i915->drm, "[ENCODER:%d:%s] [CRTC:%d:%s]\n",
encoder->base.base.id, encoder->base.name,
crtc_state->uapi.crtc->base.id, crtc_state->uapi.crtc->name);
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
index cfd7929587d8..29c40e8a7183 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
@@ -1436,7 +1436,7 @@ eb_relocate_entry(struct i915_execbuffer *eb,
if (unlikely(reloc->write_domain & (reloc->write_domain - 1))) {
drm_dbg(&i915->drm, "reloc with multiple write domains: "
"target %d offset %d "
- "read %08x write %08x",
+ "read %08x write %08x\n",
reloc->target_handle,
(int) reloc->offset,
reloc->read_domains,
@@ -1447,7 +1447,7 @@ eb_relocate_entry(struct i915_execbuffer *eb,
& ~I915_GEM_GPU_DOMAINS)) {
drm_dbg(&i915->drm, "reloc with read/write non-GPU domains: "
"target %d offset %d "
- "read %08x write %08x",
+ "read %08x write %08x\n",
reloc->target_handle,
(int) reloc->offset,
reloc->read_domains,
--
2.41.0
next prev parent reply other threads:[~2023-09-03 18:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-03 18:45 [Intel-gfx] [PATCH v2 0/6] drm_dbg: add trailing newlines where missing Jim Cromie
2023-09-03 18:45 ` [Intel-gfx] [PATCH v2 1/6] drm_dbg: add trailing newlines to msgs Jim Cromie
2023-09-03 18:45 ` [Intel-gfx] [PATCH v2 2/6] " Jim Cromie
2023-09-03 18:46 ` Jim Cromie [this message]
2023-09-04 6:32 ` [Intel-gfx] [PATCH v2 3/6] " Andi Shyti
2023-09-06 16:42 ` Rodrigo Vivi
2023-09-06 18:06 ` jim.cromie
2023-09-03 18:46 ` [Intel-gfx] [PATCH v2 4/6] " Jim Cromie
2023-09-03 18:46 ` [Intel-gfx] [PATCH v2 5/6] " Jim Cromie
2023-09-03 18:46 ` [Intel-gfx] [PATCH v2 6/6] drm: use correct ccflags-y syntax Jim Cromie
2023-09-03 19:11 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm_dbg: add trailing newlines where missing (rev2) Patchwork
2023-09-03 19:11 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-09-03 19:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-09-03 20:48 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230903184607.272198-4-jim.cromie@gmail.com \
--to=jim.cromie@gmail.com \
--cc=Jason@zx2c4.com \
--cc=airlied@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrzej.hajda@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.auld@intel.com \
--cc=robdclark@chromium.org \
--cc=rodrigo.vivi@intel.com \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox